Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The beta streaming accumulator assigned
encrypted_contentfrom everycompaction_delta. The generated delta model defaults an absent field toNone, so a later content-only delta ({"type":"compaction_delta","content":"Updated summary."}) erased metadata received earlier in the same block. The accumulator now updatesencrypted_contentonly when the field was actually present in the delta.Why
encrypted_contentis opaque metadata from a prior compaction that must be round-tripped verbatim. Treating "field omitted" as "clear the field" makes the value depend on the order of deltas: any content-only update silently drops it. A field that is explicitly sent must still take effect, includingnull(clear) and""(replace with empty).How
model_fields_setdistinguishes an omitted field from an explicitnull. Summary text accumulation is unchanged.Tests
Added a parameterized test in
tests/lib/streaming/test_parsed_content_blocks.pydrivingaccumulate_eventwith a populatedcompactionblock followed by a content-only delta, for four cases:encrypted_content"opaque"nullNone"""""new""new"ruff checkandruff format --checkpass.Fixes #1984