Repository navigation
Conversation
DomGarguilo
requested changes
Sep 21, 2026
Member
|
After looking at this PR I had the idea to reduce the default sleep time for |
Replace fixed-sleep polling loops with condition-based Wait.waitFor calls across several ITs. Co-authored-by: Dom G. <[email protected]> Co-authored-by: OpenAI GPT-5.6 Luna
ctubbsii
force-pushed
the
test-improvements
branch
from
October 1, 2026 23:31
107cbab to
268d40d
Compare
Co-authored-by: OpenAI GPT-6 Luna
DomGarguilo
reviewed
Oct 5, 2026
| getRunningCompactionInformation(ctx, ecids); | ||
| originalRunningInfoRef.set(runningInfo); | ||
| return runningInfo.values().stream().anyMatch(rci -> rci.duration > 0); | ||
| }, 30_000, 250, "Compaction did not start"); |
Member
There was a problem hiding this comment.
Take a look at the method added in #6572. It added an overload that allows us to just provide an error msg and uses the default wait and sleep values which seems like it could simplify a lot of the cases touched in this PR. Along with #6571 which reduces the default wait time to 250ms might make this PR simpler as a whole.
Member
There was a problem hiding this comment.
Made a PR against this branch on your fork at ctubbsii#23 to fix the build and make these changes
* Make var final in lambda * replace all default values with new Wait overload * Fix race with zk timeout
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace fixed-sleep polling loops with condition-based Wait.waitFor calls across several ITs.
Co-authored-by: OpenAI GPT-5.6 Luna