Repository navigation
Conversation
Amemeda
commented
Oct 15, 2026
| @NotThreadSafe | ||
| public class SeekableByteArrayInputStream extends InputStream { | ||
|
|
||
| private final byte[] buffer; |
Collaborator
Author
There was a problem hiding this comment.
this field was volatile in #3219, should it be reverted to volatile?
Contributor
There was a problem hiding this comment.
I think you might be able to leave the final modifier.
Member
There was a problem hiding this comment.
It can stay volatile, but there was a discussion previously about possibly leaking the buffer, so it's contents aren't guaranteed to be fixed: #3219 (comment)
It's kind of a separate issue, though.
Amemeda
marked this pull request as ready for review
October 15, 2026 19:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert AtomicInteger changes from #3219.
AtomicInteger curis nowvolatile int curinSeekableByteArrayInputStream.java, references and usages in class also reverted.Keeps the NotThreadSafe tag on the class.
Closes #6542