Repository navigation
Conversation
Amemeda
marked this pull request as ready for review
October 16, 2026 19:10
Collaborator
Author
Contributor
|
I think you can remove TestCachedBlockQueue as well |
Collaborator
Author
|
There is a method in BlockCacheManager.java that still has documentation referencing LRU. Unsure if this needs to be updated to TinyLFU or its talking about a different LRU like the LRU Map I see throughout the code /**
* This method provides a way for a cache implementation to access arbitrary configuration set
* by a user.
*
* <p>
* When running in a tserver, returns all Accumulo properties that have a prefix of
* {@code tserver.cache.config.<prefix>.<type>.} or
* {@code tserver.cache.config.<prefix>.default.} with values for specific cache types
* overriding defaults.
*
* <p>
* When running in a scan server, returns all Accumulo properties that have a prefix of
* {@code sserver.cache.config.<prefix>.<type>.} or
* {@code sserver.cache.config.<prefix>.default.} with values for specific cache types
* overriding defaults.
*
* <p>
* For example assume the following data is in Accumulo's system config and the plugin is
* running in a tserver.
*
* <pre>
* tserver.cache.config.lru.default.evictAfter=3600
* tserver.cache.config.lru.default.loadFactor=.75
* tserver.cache.config.lru.index.loadFactor=.55
* tserver.cache.config.lru.data.loadFactor=.65
* </pre>
*
* <p>
* If this method is called with {@code prefix=lru} and {@code type=INDEX} then it would return
* a map with the following key values. The load factor setting for index overrides the default
* value.
*
* <pre>
* evictAfter=3600
* loadFactor=.55
* </pre>
*
* @param prefix A unique identifier that corresponds to a particular BlockCacheManager
* implementation.
*/
Map<String,String> getProperties(String prefix, CacheType type); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

LruBlockCachewas depreacted in #4920 and replaced withTinyLfuBlockCache, this pr removesLruBlockCacheand related code:LruBlockCache.java: DeletedLruBlockCacheConfiguration.java: DeletedLruBlockCacheManager.java: DeletedTestlLruBlockCache.java: DeletedBlockCacheFactoryTest: Updated to remove deprecated testtestCreateLruBlockCacheFactory()CachedBlock.java: Deleted (only uses were in deleted test file)CacheBlockQueue.java: Deleted (only uses were in deleted test file)HeapSize.java: Deleted (only uses were in deleted test file)TestCachedBlockQueue: Deleted, only tested lru cache using the above 3 filesSynchronizedLoadingBlockCache.java: Moved from lru subfolder to tinylfu subfolder. Still used elsewhere in code.blockfile.cache.lrusubfolder: DeletedCloses #4921