Repository navigation
Fixes PluginEnvironment.Configuration.isSet - #6597
keith-turner wants to merge 1 commit into
Conversation
When creating a PluginEnvironment.Configuration object using PluginEnvironment.Configuration.from() the isSet method would not work properly. It should work now.
| */ | ||
| package org.apache.accumulo.core.conf; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
This will fail checkstyle rules. You need single imports.
|
I'm not sure what's going on with the checkstyle build failure, but it looks like it's some combination of a transitive dependency resolution attempt from a decommissioned maven repository, maven 3.10.0, and/or the runner's Java security config. This may be fixed by using a newer version of maven-checkstyle-plugin and/or the newer checkstyle lib as its dependency. If not, then we can probably force a maven settings file to be part of the GitHub Actions build that configures a mirror for the decommissioned maven repos that it is trying to use. What's weird is that it is also trying to use apache.snapshots, and that's disabled by default in the ASF parent POM, so it's likely hard-coded in the maven-checkstyle-plugin's POM or one of its dependencies. |
This branch has not been deployed
3 participants
When creating a PluginEnvironment.Configuration object using PluginEnvironment.Configuration.from() the isSet method would not work properly. It should work now.