Skip to content

GH-50004: [CI][Python] Revert pinning miniforge - #51898

Merged
raulcd merged 2 commits into
apache:mainfrom
adamreeve:miniforge-pin-revert
Oct 7, 2026
Merged

raulcd merged 2 commits into
apache:mainfrom
adamreeve:miniforge-pin-revert

Conversation

@adamreeve

@adamreeve adamreeve commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Rationale for this change

Undoes pinning the miniforge version, which is no longer required because miniforge now uses mamba 2.9.0, which includes the fix for mamba-org/mamba#4274. Unpinning allows us to benefit from improvements in new versions. See #49998 for context.

What changes are included in this PR?

Use the latest version of miniforge when installing it in Docker, instead of 26.1.1-3.

Are these changes tested?

They will be once CI runs 😄

Are there any user-facing changes?

No

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #50004 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added the awaiting review Awaiting review label Oct 6, 2026
@adamreeve
adamreeve marked this pull request as ready for review October 6, 2026 22:22
Copilot AI balanced review requested due to automatic review settings October 6, 2026 22:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused CI configuration change correctly removes the temporary pin after the upstream fix.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the Conda CI image to use the latest Miniforge release now that the mamba solver regression is fixed.

Changes:

  • Removes the temporary Miniforge pin and explanatory comments.
  • Installs the latest Miniforge release.
File Description
ci/​docker/​conda.dockerfile Switches Miniforge installation from version 26.1.1-3 to latest.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you also unpin

RUN /arrow/ci/scripts/install_conda.sh miniforge3 26.1.1-3 /opt/conda && \
too?

It was added by #50649 . @tadeja Can we unpin it too?

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 7, 2026
Copilot AI balanced review requested due to automatic review settings October 7, 2026 00:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused changes consistently remove the temporary pin after the fixed Mamba version was released.

Review effort: Balanced
Findings: None

@raulcd

raulcd commented Oct 7, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit verify-rc-source-*conda-*amd64

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Revision: fadee49

Submitted crossbow builds: ursacomputing/crossbow @ actions-6985bb8d80

Task Status
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-ruby-linux-conda-latest-amd64 GitHub Actions

@raulcd

raulcd commented Oct 7, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit verify-rc-source-*-ubuntu-22.04-amd64

@raulcd

raulcd commented Oct 7, 2026

Copy link
Copy Markdown
Member

sorry, was the second set of crossbow jobs not the first one :) I still require some coffee today.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Revision: fadee49

Submitted crossbow builds: ursacomputing/crossbow @ actions-9eadb49b17

Task Status
verify-rc-source-cpp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 GitHub Actions

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged as the previous failing job failure is now passing.

@raulcd
raulcd merged commit a3df197 into apache:main Oct 7, 2026
66 of 67 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 7, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Oct 7, 2026
@adamreeve
adamreeve deleted the miniforge-pin-revert branch October 7, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants