[grgrzybek]

• Reviewed all the components to use recommended UX patterns from Patternfly 6
• Removed unnecessary CSS overrides used inline with import './component.css in favor of top level index.css and artemis.css
• Clearly separated CSS overrideds for Patternfly components (like paddings and roundings) and for branding (colors)
• Backported group filtering from Andy's branch
• Moved from Tabs to NavList and inner Routes for sub-navigation
• Updated dependencies to align with @hawtio/react
• Removed hardcoded "resolutions" if newer version can be used with yarn up -R - reviewed yarn npm audit -A -R output

[jbertram]

This is excellent work @grgrzybek!

Any chance you could "squash" the commit message so it only includes the final list of relevant changes? Currently it has a lot of intermediate info (e.g. both "Upgrade to yarn 4.18.0" and "Upgrade to yarn 4.18.1", lots of instances of "ARTEMIS-6307") which could be eliminated so it's easier to digest.

[grgrzybek]

This information is from the squashed commits ;) I'll push updated PR with just one commit.

[grgrzybek]

Take your time reviewing, do not hesitate using agents and do not hesitate passing agents' bad opinion to me ;)

[jbertram]

The new navigation stuff (i.e. "Back" button works) is a great improvement!

Something is up with the message browsing functionality. Whenever I try to browse the messages on a queue I just get a blank screen. I've tried from both the "Artemis" and "Artemis JMX" views. The URL the console loads is http://localhost:8080/console/artemis/queues/messages.

[grgrzybek]

Works when I connected to Artemis 2.57.0. Could be a server JMX API change for browsing messages.

[jbertram]

I was using 2.54.0 which is what I had handy. It must be some kind of backwards compatibility issue. I think the console should be backwards compatible if possible. If not then it should fail gracefully. 👍

[grgrzybek]

Definitely - I'll try on Monday with 2.38 or earlier.

[jbertram]

I just tried with 2.57.0, and I'm still getting the same issue so it must not actually be a backwards compatibility issue (although that's still worth checking). Here's what I did to reproduce the issue:

• Create a fresh instance of 2.57.0
• Run artemis producer to populate the TEST queue with 1,000 messages
• Attempted to browse those messages via the console
• Blank screen

Perhaps the producer command is setting some kind of property with a value that's choking the console now. 🤔

[grgrzybek]

Thanks for the steps - I'll try on Monday.

[grgrzybek]

Hmm...

[GChuf]

This is great work. I'm testing stuff now - running on a broker version 2.53.0. I can see the messages and their contents without any issues.
I encountered 2 other problems, will paste them in jira.

[grgrzybek]

Thanks for checking @GChuf !

[grgrzybek]

When you create the Jiras you can already mention me.