ARTEMIS-6308 Core federation ignores max-hops and share-connection from broker.xml

[grepjava]

FileConfigurationParser.getAddressPolicy read the hops from an attribute named max-consumers, which the schema does not declare, so an address policy's max-hops was ignored and every address policy from broker.xml had maxHops = 0. It now reads max-hops.

getFederationStream never read the share-connection element the schema declares on upstreams and downstreams. It now passes it to the connection configuration.

Adds a parser test covering both, including the defaults when they are not set.

https://issues.apache.org/jira/browse/ARTEMIS-6308

[tabish121]

I would recommend you move to AMQP federation as Core federation is slated to be deprecated in the next major release

[jbertram]

@grepjava, this and #6800 are both good fixes, but I agree with @tabish121. You should move to AMQP federation. The fact that these (fairly basic) issues weren't caught in the previous years since Core federation was introduced demonstrates the lack of testing and adoption which has led us to the decision to deprecate it in favor of AMQP federation.