avoid rejecting user login if listLdapConfiguration is not allowed

[sudo87]

Description

This PR fixes the login flow for users who do not have permission to access the listLdapConfigurations API. Currently, login is blocked for these users regardless of whether LDAP is configured.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

clgtm

[Copilot]

Pull request overview

This PR adjusts the UI login/feature-discovery flow so that a user without permission to call listLdapConfigurations is not blocked from logging in, while still keeping the UI’s LDAP-enabled flag updated when LDAP config changes.

Changes:

• Stop rejecting the GetInfo flow when listLdapConfigurations fails (e.g., due to missing API permission).
• Rename the Vuex action used for refreshing the LDAP-enabled flag from UpdateConfiguration to UpdateLdapConfigurationFlag.
• Update AutogenView to dispatch the renamed action after LDAP configuration add/delete actions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
ui/src/views/AutogenView.vue	Dispatches the renamed Vuex action after LDAP config mutations.
ui/src/store/modules/user.js	Makes LDAP config listing non-fatal during GetInfo; renames the LDAP refresh action.

Comments suppressed due to low confidence (1)

ui/src/store/modules/user.js:561

• UpdateLdapConfigurationFlag wraps the API call in a new Promise(...) but never calls resolve(...) on success, so any caller awaiting dispatch('UpdateLdapConfigurationFlag') will hang indefinitely. Either call resolve(ldapEnable) inside the then(...) (and possibly resolve(false) on handled errors), or simplify by returning the api('listLdapConfigurations') promise chain directly.

    UpdateLdapConfigurationFlag ({ commit }) {
      return new Promise((resolve, reject) => {
        api('listLdapConfigurations').then(response => {
          const ldapEnable = (response.ldapconfigurationresponse.count > 0)
          commit('SET_LDAP', ldapEnable)
        }).catch(error => {
          reject(error)
        })
      })

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.16%. Comparing base (4b2d387) to head (7d925b1).

❗ There is a different number of reports uploaded between BASE (4b2d387) and HEAD (7d925b1). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (4b2d387)	HEAD (7d925b1)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #13152       +/-   ##
=============================================
- Coverage     16.39%    4.16%   -12.23%     
=============================================
  Files          5669      405     -5264     
  Lines        501541    33079   -468462     
  Branches      60925     5903    -55022     
=============================================
- Hits          82228     1378    -80850     
+ Misses       410104    31525   -378579     
+ Partials       9209      176     -9033     

Flag	Coverage Δ
uitests	4.16% <ø> (-0.01%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[andrijapanicsb]

I opened a stacked follow-up PR against this PR's source branch with the review hardening from the reproduced 4.22 issue: shapeblue#136

It keeps listLdapConfigurations non-fatal during login, but also resets LDAP state to boolean false, guards missing/ignored responses, resolves UpdateLdapConfigurationFlag, and suppresses the generic optional-discovery 401 notification for this probe.

[andrijapanicsb]

Update: I pushed the follow-up hardening directly into this PR branch now that I confirmed write access to shapeblue/cloudstack:skipRejectionLdapConfig.

The PR now includes commit d9b85efc15, which:

• keeps denied listLdapConfigurations non-fatal during login,
• resets LDAP state to boolean false instead of {},
• guards the LDAP count response,
• resolves UpdateLdapConfigurationFlag on success,
• suppresses the optional-discovery 401 notification for this probe.

The temporary stacked PR is now merged/superseded: shapeblue#136

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17859

[andrijapanicsb]

@wido we need some help ;)

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13152 (QA-JID-933)

[DaanHoogland]

clgtm

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@sudo87 can you solve the conflict?

[DaanHoogland]

@sudo87 , did you address the comments #13152 (comment) and #13152 (comment) ?

[sudo87]

@DaanHoogland yes conflicts are resolved in this pr. Is there any other comment to address?

[sudo87]

@blueorangutan ui

[blueorangutan]

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13152 (QA-JID-1000)