Conversation
Collaborator
Author
|
@blueorangutan package |
|
@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14301 +/- ##
============================================
- Coverage 19.91% 19.91% -0.01%
Complexity 20199 20199
============================================
Files 6373 6373
Lines 577230 577233 +3
Branches 70696 70696
============================================
- Hits 114950 114946 -4
- Misses 449713 449719 +6
- Partials 12567 12568 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19390 |
Collaborator
Author
|
closing, mitch already has #14249 up for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14248
Listing IPs on a shared network with forvirtualnetwork=false sometimes fails with a 530 and "this.instanceId is null". The virtual router has two NIC rows for its IP on a shared network: a placeholder with no VM attached, and the real one. The lookup could return either, and when it picked the placeholder the router branch tried to read its missing VM id and crashed. This makes the lookup skip placeholder NICs, so the router's real NIC is always used.