Repository navigation
Make vpc.max.networks dynamic and return a useful error at the limit - #14373
MitchDrage wants to merge 1 commit into
Conversation
| "3", | ||
| "Maximum number of networks per VPC. Can be overridden per domain and per account", | ||
| true, | ||
| List.of(ConfigKey.Scope.Account, ConfigKey.Scope.Domain)); |
There was a problem hiding this comment.
can a domain admin now raise this for their own domain? they can change account and domain settings, so the operator cap stops being a cap
There was a problem hiding this comment.
Thanks Damans. You were right - a domain admin could change the setting for their domain.
Since I've pivoted the idea here, it's no longer applicable as it's back to being a global setting. See the other comment in the PR and the new description.
5d6ffb0 to
d95452e
Compare
|
I've changed direction on this PR. Per-account/domain values aren't needed: the cap exists to handle the technical limitation of the VR's NIC capacity which is the same for every tenant, and VPC tiers already count toward the account and domain guest network limits. |
Description
vpc.max.networksto be dynamic, so changes no longer need a restart.Messages:
Original (HTTP 530):
Internal error executing command, please contact your system administratorNumber of networks per VPC cannot surpass [3].New (HTTP 431, all users):
VPC web-prod has reached the maximum of 3 networks. Delete an unused network or contact your platform administrator to raise the limit.Closes #14372
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
N/A
How Has This Been Tested?
How did you try to break this feature and the system with this change?
servermodule test suite. All tests pass.