Repository navigation
[POOL-432] Guard monitor recovery when no adder exists - #460
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex gpt-6-luna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses POOL-432. When a factory failure is recorded with no waiting borrowers, no adder thread is created. After successful makes evict the failure from the log,
runChecks()recovers the factory but previously calledadder.kill()unconditionally, throwing aNullPointerExceptionand terminating the monitor.Guard the adder shutdown when no adder exists, and add a synthetic failing-factory regression for the failure/recovery transition.
Validation:
NullPointerExceptionand passed after the fix.mvn clean verifypassed (Maven 3.9.11, Temurin JDK 26.0.2.1).AI-generated text: this PR description was drafted with OpenAI Codex (gpt-6-luna); no human review had occurred when it was submitted. The commit includes the tool provenance token recommended by ASF guidance.