Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ public List<IDatabaseTypeRule> getTypeRules() {

private static final Class<?> PKG = MariaDBDatabaseMeta.class;

private static final String SQL_SELECT_SEQUENCES =
"SELECT TABLE_NAME AS sequence_name FROM INFORMATION_SCHEMA.TABLES"
+ " WHERE TABLE_TYPE = 'SEQUENCE' AND ";

private static final Set<String> SHORT_MESSAGE_EXCEPTIONS =
Sets.newHashSet("org.mariadb.jdbc.internal.stream.MaxAllowedPacketException");

Expand Down Expand Up @@ -89,6 +93,76 @@ public boolean isFullExceptionLog(Exception e) {
return !(cause != null && SHORT_MESSAGE_EXCEPTIONS.contains(cause.getClass().getName()));
}

/** MariaDB supports sequences natively since 10.3, unlike MySQL. */
@Override
public boolean isSupportsSequences() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix

With sequences enabled, the SQL button in Dimension lookup and Combination lookup now generates a CREATE SEQUENCE for MariaDB. They pass max value -1 ("no maximum"), and since MariaDB doesn't report a no-max-value option, the statement ends in MAXVALUE -1. MariaDB rejects it:

ERROR 4085 (HY000): Sequence 'hop.dim_seq' has out of range value for options

MariaDB accepts NOMAXVALUE, which BaseDatabaseMeta.getSequenceNoMaxValueOption() already returns, so this override is enough:

@Override
public boolean isSupportsSequenceNoMaxValueOption() {
  return true;
}

We tried it: the generated DDL ends in NOMAXVALUE, runs on MariaDB 10.11, and NEXTVAL returns 1. An assertion on isSupportsSequenceNoMaxValueOption() in MariaDBSequenceAndReleaseSavePointTest would cover it.

return true;
}

/**
* MariaDB accepts NOMAXVALUE in CREATE SEQUENCE but rejects MAXVALUE -1, which Hop would
* otherwise generate for a sequence without a maximum value.
*/
@Override
public boolean isSupportsSequenceNoMaxValueOption() {
return true;
}

/** Sequences are listed from the current database, where MariaDB stores them as tables. */
@Override
public String getSqlListOfSequences() {
return SQL_SELECT_SEQUENCES + "TABLE_SCHEMA = DATABASE()";
}

/**
* Check if a sequence exists. The name may be qualified with a database (schema) name and quoted
* with backticks, as Hop passes it; without a database the current one is searched.
*
* @param sequenceName The sequence to check
* @return The SQL to get the name of the sequence back from the information schema
*/
@Override
public String getSqlSequenceExists(String sequenceName) {
String name = sequenceName.replace(getStartQuote(), "").replace(getEndQuote(), "");
int dotPos = name.indexOf('.');
String schemaCondition = "TABLE_SCHEMA = DATABASE()";
if (dotPos != -1) {
schemaCondition = "TABLE_SCHEMA = '" + escapeLiteral(name.substring(0, dotPos)) + "'";
name = name.substring(dotPos + 1);
}
return SQL_SELECT_SEQUENCES
+ schemaCondition
+ " AND TABLE_NAME = '"
+ escapeLiteral(name)
+ "'";
}

/**
* Get the SQL to get the next value of a sequence.
*
* @param sequenceName The sequence name
* @return the SQL to get the next value of a sequence.
*/
@Override
public String getSqlNextSequenceValue(String sequenceName) {
return "SELECT NEXTVAL(" + sequenceName + ")";
}

/**
* Get the SQL to get the current value of a sequence: the last value generated in this session.
*
* @param sequenceName The sequence name
* @return the SQL to get the current value of a sequence.
*/
@Override
public String getSqlCurrentSequenceValue(String sequenceName) {
return "SELECT LASTVAL(" + sequenceName + ")";
}

private static String escapeLiteral(String value) {
return value.replace("'", "''");
}

/**
* Returns the column name for a MariaDB field.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,56 @@ class MariaDBSequenceAndReleaseSavePointTest {

// Set these parameters for the test
IDatabase db = new MariaDBDatabaseMeta();
Boolean sequenceSupport = false;
Boolean sequenceSupport = true;
Boolean savepointSupport = false;

@Test
void testSequenceSupport() {
assertSupports(db, sequenceSupport);
assertEquals("", db.getSqlNextSequenceValue(sequenceName));
assertEquals("", db.getSqlCurrentSequenceValue(sequenceName));
assertEquals("SELECT NEXTVAL(sequence_name)", db.getSqlNextSequenceValue(sequenceName));
assertEquals("SELECT LASTVAL(sequence_name)", db.getSqlCurrentSequenceValue(sequenceName));
assertEquals(
"SELECT TABLE_NAME AS sequence_name FROM INFORMATION_SCHEMA.TABLES"
+ " WHERE TABLE_TYPE = 'SEQUENCE' AND TABLE_SCHEMA = DATABASE()",
db.getSqlListOfSequences());
}

@Test
void testSequenceNoMaxValueOption() {
// MariaDB rejects MAXVALUE -1 in CREATE SEQUENCE, so a sequence without a maximum value must
// use NOMAXVALUE
assertTrue(db.isSupportsSequenceNoMaxValueOption());
assertEquals("NOMAXVALUE", db.getSequenceNoMaxValueOption());
}

@Test
void testSequenceExistsInCurrentDatabase() {
assertEquals(
"SELECT TABLE_NAME AS sequence_name FROM INFORMATION_SCHEMA.TABLES"
+ " WHERE TABLE_TYPE = 'SEQUENCE' AND TABLE_SCHEMA = DATABASE()"
+ " AND TABLE_NAME = 'sequence_name'",
db.getSqlSequenceExists(sequenceName));
}

@Test
void testSequenceExistsInQuotedSchema() {
// Hop passes schema-qualified names quoted the MySQL way, e.g. `sales`.`order_seq`
assertEquals(
"SELECT TABLE_NAME AS sequence_name FROM INFORMATION_SCHEMA.TABLES"
+ " WHERE TABLE_TYPE = 'SEQUENCE' AND TABLE_SCHEMA = 'sales'"
+ " AND TABLE_NAME = 'order_seq'",
db.getSqlSequenceExists("`sales`.`order_seq`"));
assertEquals(
"SELECT NEXTVAL(`sales`.`order_seq`)", db.getSqlNextSequenceValue("`sales`.`order_seq`"));
}

@Test
void testSequenceExistsEscapesQuotes() {
assertEquals(
"SELECT TABLE_NAME AS sequence_name FROM INFORMATION_SCHEMA.TABLES"
+ " WHERE TABLE_TYPE = 'SEQUENCE' AND TABLE_SCHEMA = DATABASE()"
+ " AND TABLE_NAME = 'o''seq'",
db.getSqlSequenceExists("o'seq"));
}

@Test
Expand Down