Skip to content

remove need to have SWT on the classpath for headless runs, fixes #9501 - #9503

Merged
bamaer merged 1 commit into
apache:mainfrom
hansva:9501
Nov 16, 2026
Merged

bamaer merged 1 commit into
apache:mainfrom
hansva:9501

Conversation

@hansva

@hansva hansva commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bamaer bamaer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hansva, LGTM. No blockers or should-fix items.

Built the PR and ran it with lib/swt removed from the class path of hop-run.sh, hop-conf.sh and hop-server.sh (client plus the 43 marketplace plugins):

  • hop-run: samples pipelines and workflows, including run-pipeline-tests.hwf and a project with an SMB connection, all finish.
  • hop-conf -pl and hop-conf --help work, with all config plugin options listed (lint and Dropbox included).
  • hop-server: a remote pipeline run, the status page and the pipeline image work.
  • On the merge-base, the same hop-run and hop-conf commands stop in HopEnvironment.init() with NoClassDefFoundError: org/eclipse/swt/widgets/Dialog.
  • The new tests pass, and fail against the merge-base code.
  • Every plugin class a headless Hop registers (811) loads and reflects without SWT. Only GUI-event extension points still need it, and those don't fire headless.

@bamaer
bamaer merged commit 50991a5 into apache:main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants