Repository navigation
remove need to have SWT on the classpath for headless runs, fixes #9501 - #9503
Merged
Merged
Conversation
bamaer
reviewed
Nov 16, 2026
bamaer
left a comment
Contributor
There was a problem hiding this comment.
Thanks @hansva, LGTM. No blockers or should-fix items.
Built the PR and ran it with lib/swt removed from the class path of hop-run.sh, hop-conf.sh and hop-server.sh (client plus the 43 marketplace plugins):
- hop-run: samples pipelines and workflows, including
run-pipeline-tests.hwfand a project with an SMB connection, all finish. hop-conf -plandhop-conf --helpwork, with all config plugin options listed (lint and Dropbox included).- hop-server: a remote pipeline run, the status page and the pipeline image work.
- On the merge-base, the same hop-run and hop-conf commands stop in
HopEnvironment.init()withNoClassDefFoundError: org/eclipse/swt/widgets/Dialog. - The new tests pass, and fail against the merge-base code.
- Every plugin class a headless Hop registers (811) loads and reflects without SWT. Only GUI-event extension points still need it, and those don't fire headless.
bamaer
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.