Skip to content

Untranslated strings from Weblate show up as blank labels, fixes #9502 - #9504

Merged
bamaer merged 1 commit into
apache:mainfrom
hansva:9502
Nov 16, 2026
Merged

bamaer merged 1 commit into
apache:mainfrom
hansva:9502

Conversation

@hansva

@hansva hansva commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bamaer bamaer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hansva, LGTM.

Built core and ran the i18n tests: all pass, and 2 of the 3 new tests fail with the GlobalMessageUtil change reverted. Also resolved every empty key that the Weblate PR #9488 adds to core's bundles: 1,390 that come back blank on main resolve to the en_US text with this PR. No bundle on main has empty values today, so nothing that works now changes.

@bamaer
bamaer merged commit f7ad97c into apache:main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants