Skip to content

fix(json): return a parse error for a decimal precision above 38 #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 1 commit into from
Closed

fix(json): return a parse error for a decimal precision above 38 #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/iceberg/json_serde.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,9 @@ Result<std::unique_ptr<Type>> TypeFromJson(const nlohmann::json& json) {
StringUtils::ParseNumber<int32_t>(match[1].str()));
ICEBERG_ASSIGN_OR_RAISE(auto scale,
StringUtils::ParseNumber<int32_t>(match[2].str()));
if (precision > DecimalType::kMaxPrecision) {
return JsonParseError("Invalid decimal type: {}", type_name);
}
return std::make_unique<DecimalType>(precision, scale);
}
return JsonParseError("Invalid decimal type: {}", type_name);
Expand Down
7 changes: 7 additions & 0 deletions src/iceberg/test/schema_json_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ INSTANTIATE_TEST_SUITE_P(
SchemaField::MakeRequired(1, "id", iceberg::int32()),
SchemaField::MakeOptional(2, "name", iceberg::string())})}));

TEST(TypeJsonTest, FromJsonOutOfRangeDecimalPrecisionIsParseError) {
// Precision beyond the supported maximum must surface as a parse error,
// not an uncaught IcebergError from the DecimalType constructor.
auto result = TypeFromJson(nlohmann::json::parse("\"decimal(39, 2)\""));
EXPECT_THAT(result, IsError(ErrorKind::kJsonParseError));
}

TEST(TypeJsonTest, FromJsonWithSpaces) {
auto fixed_json = R"("fixed[ 8 ]")";
auto fixed_result = TypeFromJson(nlohmann::json::parse(fixed_json));
Expand Down
Loading