Repository navigation
build: avoid duplicate libraries in the C++20 compatibility test - #1015
Merged
Merged
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
0 open findings
What changed in this PR
Scopes CMake policy changes to the C++20 compatibility test to allow CMake to de-duplicate duplicate-linked libraries (avoiding macOS linker warnings) without affecting other targets or requiring newer CMake versions.
Changes:
- Pushes a CMake policy scope for the C++20 compatibility test.
- Enables CMP0156 and CMP0179 when available to allow link-library de-duplication / first-static behavior.
- Pops the policy scope at the end of the test target configuration.
| File | Description |
|---|---|
| src/iceberg/test/CMakeLists.txt | Adds scoped CMake policy changes (CMP0156/CMP0179) around the C++20 compatibility test target to reduce duplicate-library warnings. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped reviewing on behalf of
wgtmac due to an error
October 14, 2026 06:34
manuzhang
approved these changes
Oct 14, 2026
blackmwk
approved these changes
Oct 15, 2026
Member
Author
|
Thanks all for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++20 compatibility test links core/data libraries both directly and through optional components, which can produce duplicate-library warnings on macOS.
Enable CMP0156 and CMP0179 when available, scoped to this test. CMake can then de-duplicate libraries where the linker supports it and keep the first static-library occurrence. Older CMake versions keep the existing behavior. Dependencies and public-header coverage are unchanged; no warning is suppressed.
Validation: pre-commit and git diff --check passed. No build or tests were run, as requested.