Repository navigation
fix(cpp): restore Arrow 17 devcontainer compatibility - #952
Conversation
Support the Arrow 17 compute and Parquet reader APIs packaged by the published development container while preserving the Arrow 21+ path. Tests: graphar-cpplint; CMake build; ctest (20/20) in devcontainer Fixes: apache#945
|
CI audit for the current head
These outcomes occur before a workflow job starts on this fork PR; they are not test failures. The local devcontainer evidence in the PR body covers the affected C++ scope: cpplint, Debug CMake build, and CTest 20/20. The submitting token cannot approve upstream workflow runs (GitHub returns |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
============================================
+ Coverage 77.40% 81.65% +4.25%
Complexity 615 615
============================================
Files 84 95 +11
Lines 8957 11153 +2196
Branches 1069 1070 +1
============================================
+ Hits 6933 9107 +2174
- Misses 1784 1806 +22
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Review feedback on apache#952. Including arrow/util/config.h in fwd.h coupled the info API chain (api/info.h -> graph_info.h/types.h/result.h) to Arrow. Since the graphar target links Arrow PRIVATE and graphar-config.cmake does not export the Arrow include directories, a downstream consumer of the info API alone would need Arrow development headers on its include path. Every use of ARROW_VERSION in this branch is in a translation unit that already depends on Arrow, so the include belongs there instead. Also spell the version checks as defined(ARROW_VERSION) && ..., matching the checks already present in filesystem.cc and util.h. Verified in ghcr.io/apache/graphar-dev:latest (Arrow 17): a translation unit including only graphar/graph_info.h compiles with the Arrow headers removed from the include path, which fails before this change; the full Debug build succeeds and ctest reports 20/20 passed.
Reason for this PR
Fixes #945. The published
ghcr.io/apache/graphar-dev:latestimage packages Arrow, Dataset, Acero, and Parquet 17.0.0, while the current C++ code unconditionally calls newer compute APIs and tests call the newer Parquet reader API. The C++ build therefore fails before it can act as the compatibility oracle for GraphAr metadata.What changes are included in this PR?
ReadTableAPI.Are these changes tested?
Yes, in
ghcr.io/apache/graphar-dev:lateston Linux arm64:cmake --build /build --target graphar-cpplintBUILD_TESTS=ON,BUILD_EXAMPLES=OFF,BUILD_BENCHMARKS=OFF, and sanitizers disabledGAR_TEST_DATA=/workspace/incubator-graphar/testing ctest --test-dir /build --output-on-failure— 20 tests passed, 0 failed.Are there any user-facing changes?
No public GraphAr API or format semantics change. This restores the supported C++ build/test path in the published devcontainer.
Checklist
make cpplintbefore submitting when changed files are in thecppdirectory.pre-commit runbefore commit the changed files. The command is not installed on the host or the declared devcontainer.