Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Closes #976.
The in-tree Rust binding exposes vertex data builders and edge metadata, but it cannot write edge data even though the C++ implementation already owns
graphar::builder::EdgeandEdgesBuilder. Rust consumers therefore cannot stay on the upstream GraphAr writer path for graph-shaped data.What changes are included in this PR?
EdgeandEdgesBuilderwrappers over the existing C++ implementation;No GraphAr encoding, metadata format, or chunk layout is reimplemented in Rust.
Are these changes tested?
Yes. New tests cover endpoint/property access, negative IDs, successful upstream chunk writing, unavailable adjacency layouts, and strong schema rejection. Locally:
cargo test: 58 passed;cargo clippy --tests --no-deps -- -D warnings: passed;cargo test --doc: passed;cargo doc --lib --no-deps: passed;cargo fmt --all -- --check: passed.Are there any user-facing changes?
Yes. Rust users gain public
graphar_rs::builder::{Edge, EdgesBuilder}APIs. Existing APIs are unchanged.Checklist
make cpplintbefore submitting when changed files are in thecppdirectory. (No files undercpp/changed.)pre-commit runon the changed files before submission; the Rust format gate was also run directly through the project Cargo environment.