Skip to content

Revert "[Fix] Prevent silent subscription data loss on WAL replay gaps (#18741)" - #18786

Merged
jt2594838 merged 2 commits into
masterfrom
revert-silent
Sep 30, 2026
Merged

jt2594838 merged 2 commits into
masterfrom
revert-silent

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

This reverts commit 0c9fb83.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Revert "[Fix] Prevent silent subscription data loss on WAL replay gap… Revert "[Fix] Prevent silent subscription data loss on WAL replay gaps (#18741)" Sep 30, 2026
@jt2594838
jt2594838 merged commit bbe6364 into master Sep 30, 2026
37 of 39 checks passed
@jt2594838
jt2594838 deleted the revert-silent branch September 30, 2026 14:18
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.55%. Comparing base (0c9fb83) to head (e49d9ad).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...on/broker/consensus/ConsensusPrefetchingQueue.java 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18786      +/-   ##
============================================
+ Coverage     45.54%   45.55%   +0.01%     
  Complexity      712      712              
============================================
  Files          5483     5483              
  Lines        396324   396283      -41     
  Branches      51575    51565      -10     
============================================
+ Hits         180505   180527      +22     
+ Misses       215819   215756      -63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants