Repository navigation
chore(deps): update actions/setup-java digest to b843ebf - #6827
Conversation
milamberspace
left a comment
There was a problem hiding this comment.
The change itself looks fine — b843ebf is the commit behind the official v6.1.0 / v6 tags of actions/setup-java (9 upstream commits since v6.0.1, all features/fixes), and the action stays SHA-pinned with the # v6 comment. Not approving yet only because CI is red, and the red is unrelated to this diff.
CI failure (unrelated)
The modified workflow (gradle-dependency-submit.yaml) is not part of PR CI. The only failing job, 17, corretto, macos, UTC, fr_FR, failed on two different timing-sensitive tests across two attempts:
- attempt 1:
:src:dist-check:batchServerBatchTestLocal— unexpected size ofBatchTestLocal.csv/BatchTestLocal.xml(the flakiness addressed by #6831) - attempt 2:
SamplerMetricTimedModeTest.checkAddCumulatedKo—ko.max ==> expected: <1000.0> but was: <1048.0>
Both look like macOS runner timing flakiness rather than anything introduced here.
This review was drafted by an AI-assisted tool and
confirmed by an Apache JMeter maintainer. The findings
below are observations, not blockers; an Apache JMeter
maintainer — a real person — will take the next look at the
PR. If you think a finding is mis-applied, please reply on
the PR and a maintainer will weigh in.More on how Apache JMeter handles maintainer review:
Contributing guide.
This PR contains the following updates:
de7274f→b843ebfConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.