Repository navigation
Fix #1813: expect the Maven 3.9 classpath order in get-classpath IT - #1814
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…h IT The get-classpath IT hard-coded the Maven 3.10/4 classpath order (runtime before leaf). On Maven 3.9 and earlier (Resolver 1.x), a transitive dependency reached only through another dependency sorts before that dependency's direct siblings, so the actual order is leaf before runtime. The goal was correct; the IT's expectation was not. Build the expected order per Maven version, the same way the IT already does for the leaf's own version. Claude-Session: https://claude.ai/code/session_01BrsHTdDq7PD1DoqeA9vs66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1813: the get-classpath IT's
verify.groovyhard-coded the classpath order as[lib, dep, runtime, leaf], but that's only correct on Maven 3.10+/4 (Resolver 2.x). On Maven 3.9 and earlier (Resolver 1.x), a transitive dependency reached only through another dependency (the leaf, reached via dep) sorts before that dependency's own sibling (runtime), so the actual order is[lib, dep, leaf, runtime]. The goal itself is correct; the IT's expectation wasn't. CI only runs Maven 3.10/4, so this never showed up there, but it fails on Maven 3.9.16 which the plugin's own<prerequisites>still allows.Build the expected order per Maven version, the same way the IT already does for the leaf's own version.
Reproduced the exact failure from the issue on real Maven 3.9.16 before the fix, confirmed it passes after.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following: