Skip to content

feat(core-spec): add TRINO to Dialect enum #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MahmoudHassanen99 wants to merge 19 commits into
base: main
Choose a base branch
from
+6 −1
Open

feat(core-spec): add TRINO to Dialect enum #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
449de8f
Add Trino SQL to the specification
MahmoudHassanen99 Oct 18, 2026
0300bba
Add 'TRINO' to supported dialects in schema
MahmoudHassanen99 Oct 18, 2026
9167c6d
Correct casing of 'Trino' to 'TRINO' in spec
MahmoudHassanen99 Oct 18, 2026
d999330
Add Trino SQL to supported languages in spec.yaml
MahmoudHassanen99 Oct 18, 2026
c898daf
Add TRINO to data source enumeration
MahmoudHassanen99 Oct 18, 2026
fbef34f
Add Trino SQL to supported languages
MahmoudHassanen99 Oct 18, 2026
d6ac958
Add Trino to skip SQL validation list
MahmoudHassanen99 Oct 18, 2026
8e54c60
Add Trino to SKIP_SQL_VALIDATION dictionary
MahmoudHassanen99 Oct 18, 2026
7164bbf
Remove Trino from validation skip list
MahmoudHassanen99 Oct 18, 2026
2173fc7
Add support for Trino dialect in OSSIE converter
MahmoudHassanen99 Oct 24, 2026
62671a2
Merge branch 'apache:main' into main
MahmoudHassanen99 Oct 24, 2026
388971e
Add Trino dialect to SQL dialect mapping test
MahmoudHassanen99 Oct 24, 2026
a0baf41
Add 'trino' to valid dialect choices in tests
MahmoudHassanen99 Oct 24, 2026
50036fa
Add 'TRINO' to SQL dialects list
MahmoudHassanen99 Oct 24, 2026
2e7c9a8
Add TRINO to SQL dialect enumeration
MahmoudHassanen99 Oct 24, 2026
8977de9
Fix syntax error in sqlrefs.py
MahmoudHassanen99 Oct 24, 2026
96446cc
Fix formatting in limitations.md for SQL dialect list
MahmoudHassanen99 Oct 24, 2026
9eac4fb
Add Trino dialect to OSSIE dialect mapping
MahmoudHassanen99 Oct 24, 2026
47b02e3
fix: resolve merge conflicts with main
MahmoudHassanen99 Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-spec/ossie-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"$defs": {
"Dialect": {
"type": "string",
"enum": ["ANSI_SQL", "SNOWFLAKE", "MDX", "TABLEAU", "DATABRICKS", "MAQL", "BIGQUERY", "SIGMA", "THOUGHTSPOT", "DAX", "HOLISTICS_AQL", "OSSIE_SQL_2026"],
"enum": ["ANSI_SQL", "SNOWFLAKE", "MDX", "TABLEAU", "DATABRICKS", "MAQL", "BIGQUERY", "SIGMA", "THOUGHTSPOT", "DAX", "HOLISTICS_AQL", "OSSIE_SQL_2026", "TRINO"],
"description": "Supported SQL and expression language dialects"
},
"Vendor": {
Expand Down
1 change: 1 addition & 0 deletions core-spec/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Dialects in which metric and field expressions can be declared.
| `DAX` | Data Analysis Expressions (Power BI / Analysis Services) |
| `HOLISTICS_AQL` | Holistics AQL (Analytical Query Language) |
| `OSSIE_SQL_2026` | Ossie's portable SQL expression language, defined in `expression_language.md` |
| `TRINO` | Trino SQL |

`OSSIE_SQL_2026` is the only dialect whose semantics this specification defines. The other values
identify vendor or third-party expression languages. Ossie treats expressions in those dialects as
Expand Down
1 change: 1 addition & 0 deletions core-spec/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ dialects:
- "DAX" # Data Analysis Expressions (Power BI / Analysis Services)
- "HOLISTICS_AQL" # Holistics AQL (Analytical Query Language)
- "OSSIE_SQL_2026" # Ossie portable SQL expression language (see expression_language.md)
- "TRINO" # Trino SQL

# Supported logical data types for fields and metrics
# Auto-generated from ossie-schema.json ($defs.DataType.enum).
Expand Down
1 change: 1 addition & 0 deletions python/src/ossie/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ class OssieDialect(str, Enum):
DAX = "DAX"
HOLISTICS_AQL = "HOLISTICS_AQL"
OSSIE_SQL_2026 = "OSSIE_SQL_2026"
TRINO = "TRINO"


class OssieDataType(str, Enum):
Expand Down
1 change: 1 addition & 0 deletions scripts/generate-spec-types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"DAX": "Data Analysis Expressions (Power BI / Analysis Services)",
"HOLISTICS_AQL": "Holistics AQL (Analytical Query Language)",
"OSSIE_SQL_2026": "Ossie portable SQL expression language (see expression_language.md)",
"TRINO": "Trino SQL",
},
},
{
Expand Down
1 change: 1 addition & 0 deletions validation/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
"THOUGHTSPOT": None, # Not supported by sqlglot, skip validation
"DAX": None, # Not supported by sqlglot, skip validation
"HOLISTICS_AQL": None, # Holistics AQL, not SQL; skip validation
"TRINO": "trino",
}

# Dialects that sqlglot cannot parse
Expand Down
Loading