Repository navigation
HDDS-17446. Avoid copying the datanode container set twice - #11746
Merged
Merged
Conversation
Contributor
Author
|
cc @peterxcli |
Contributor
|
Thanks @andyhuangdev for the patch, @peterxcli for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
NodeStateMap.updateNode calls oldEntry.copyContainers(), which creates a new set, and the DatanodeEntry constructor copies that set again with addAll.
This change passes the old DatanodeEntry directly to the constructor so the containers are copied once. It avoids an intermediate set allocation while preserving an independent container set for the new entry.
Follow-up to the review comment on #11687.
What is the link to the Apache JIRA
HDDS-17446
How was this patch tested?
Passed TestSCMNodeManager#testRegisterKeepsContainersOnNodeUpdate, which verifies that containers are preserved when a datanode re-registers with a new version, ports, or IP address.