Repository navigation
WW-3720 test(core): cover comma-delimited interceptor params split across lines - #2040
Merged
Merged
Conversation
…ross lines Pins that a multi-line <param> value such as excludeMethods is parsed into separate method names, both on the interceptor definition and on an interceptor-ref override. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
lukaszlenart
marked this pull request as ready for review
October 17, 2026 13:08
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to WW-3720
Summary
WW-3720 asks for a
<list><element>…</element></list>form for collection-valued params such asexcludeMethods. The readability need behind it is already met: a comma-delimited value can be split across lines inside one<param>, because bothXmlHelper.getContentandTextParseUtil.commaDelimitedStringToSettrim whitespace.This PR is test-only. It pins that behaviour end to end (XML file → configuration → built
DefaultWorkflowInterceptor), both on the interceptor definition and on aninterceptor-refoverride, so the multi-line form stays supported.A real
<list>element isn't proposed: params areMap<String, String>throughout the config model (XML,InterceptorConfig/ActionConfig,DefaultInterceptorFactory, lazy params, Convention's@InterceptorRef(params = …)), and the comma-string convention is shared by many interceptors across core and plugins.Verification
XmlConfigurationProviderInterceptorsTest: 5/5 pass on current code..map(String::trim)removed fromcommaDelimitedStringToSet, the new test fails withexpected:<[cancel, back, input]> but was:<[input,\n back,\n cancel]>, so it covers the trimming path.🤖 Generated with Claude Code