Skip to content

Add an ignored PageRank test for a local Twitter2010 edge list - #2627

Closed
kubraaksux wants to merge 1 commit into
apache:mainfrom
kubraaksux:pagerank-twitter2010
Closed

kubraaksux wants to merge 1 commit into
apache:mainfrom
kubraaksux:pagerank-twitter2010

Conversation

@kubraaksux

@kubraaksux kubraaksux commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Add testPageRankTwitter2010 to PageRankTest. The test is @ Ignore because the Twitter2010 edge list stays local and is not part of this repository.

The edge list path comes from -Dsysds.test.twitter2010 or TWITTER2010_EDGES. The test builds the column-stochastic link matrix and checks the same PageRank update as the existing test.

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.47%. Comparing base (8ddd380) to head (11daa87).

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2627       +/-   ##
=============================================
- Coverage     75.53%   71.47%    -4.06%     
- Complexity        0    51144    +51144     
=============================================
  Files           454     1646     +1192     
  Lines         29799   198704   +168905     
  Branches          0    38636    +38636     
=============================================
+ Hits          22508   142021   +119513     
- Misses         7291    45509    +38218     
- Partials          0    11174    +11174     
Flag Coverage Δ
java 71.47% <ø> (?)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywcb00 ywcb00 self-assigned this Nov 2, 2026
@ywcb00 ywcb00 closed this Nov 2, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SystemDS PR Queue Nov 2, 2026
@ywcb00

ywcb00 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you very much for adding this test @kubraaksux.
During the merge, I introduced a test parameter to indicate the dataset. Combining both test settings into a unified method helps to avoid creating artificial tests which evaluate to success directly (i.e., runPageRankTwitter2010() with numRows > 50).

Thanks and all the best,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants