Skip to content

[SYSTEMDS-3979] Reuse Existing Transient Writes when Splitting DAG - #2628

Closed
ywcb00 wants to merge 1 commit into
apache:mainfrom
ywcb00:fix/recompile/sparsity/mmchain
Closed

ywcb00 wants to merge 1 commit into
apache:mainfrom
ywcb00:fix/recompile/sparsity/mmchain

Conversation

@ywcb00

@ywcb00 ywcb00 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

This PR prevents the splitting mechanism from introducing transient reads and writes redundantly when existing writes can be reused. This issue has already been treated for data dependent split rewriting (different rewrite class).
This PR also adds a test case which revealed the issue.

…xisting transient writes instead of introducing redundant transient reads and writes
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.02%. Comparing base (8ddd380) to head (da4cb62).

Files with missing lines Patch % Lines
...hops/rewrite/RewriteSplitDagSparsityRecompile.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2628       +/-   ##
=============================================
- Coverage     75.53%   72.02%    -3.51%     
- Complexity        0    51160    +51160     
=============================================
  Files           454     2100     +1646     
  Lines         29799   228514   +198715     
  Branches          0    38640    +38640     
=============================================
+ Hits          22508   164585   +142077     
- Misses         7291    52769    +45478     
- Partials          0    11160    +11160     
Flag Coverage Δ
java 71.50% <93.33%> (?)
python 75.49% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywcb00 ywcb00 closed this in 978e0bf Oct 30, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SystemDS PR Queue Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants