Repository navigation
[CPP] Support reading BOOLEAN RLE written with Java defaults - #1019
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java writes BOOLEAN columns with RLE by default, but the C++ decoder factory rejects BOOLEAN + RLE even though
Int32RleDecoder::read_boolean()already exists. Reading these files therefore fails when the reader allocates the value decoder.This change routes BOOLEAN + RLE to the existing decoder and adds a factory regression test. The existing cross-language compatibility workflow now generates 12 additional Java fixtures using a schema with no explicit encoding, asserts that the Java default is RLE, and validates the on-wire encoding and every value in C++. The fixtures cover UNCOMPRESSED/LZ4/ZSTD/LZMA2, alternating bits, long true/false runs, mixed NULL pages, and all-NULL pages.
Validation:
git diff --checkpassed.