Repository navigation
[CPP] Preserve embedded NUL bytes in DICTIONARY strings - #1022
Merged
ColinLeeo merged 1 commit intoOct 18, 2026
Merged
Conversation
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DICTIONARY decoding in C++ truncated TEXT/STRING values at the first NUL byte because
read_var_strconstructed a C string without its encoded length. Preserve the full byte length, including empty values and embedded/trailing NULs.Adds a Java-generated binary dictionary golden test, a C++ dictionary round trip, and a var-string regression spanning ByteStream pages.
Validation: 33 byte-stream/dictionary tests passed; C++ Spotless and
git diff --checkpassed. This addresses the dictionary failure exposed by #1021 independently of the compatibility-matrix expansion.Combined verification with both independent fixes and the #1021 matrix passed: Java-to-C++ 954/954 files and C++-to-Java 918/918 files, including all three scales and six compressors. The SPRINTZ fixtures were regenerated with the corrected writers; the original non-SPRINTZ corpus was retained.