Conversation
Expose the shell and React unit checks as named frontend workflow steps and run React tests and typechecking from the Maven test phase. Fix the existing ES5-compatible Uint8Array assertion so the React typecheck can become a gate. Update the scoped test guidance to describe the new command and CI surfaces. Confidence: high Scope-risk: additional frontend CI duration and newly enforced React failures Not-tested: GitHub-hosted workflow execution
Disable fail-fast on the run-playwright-e2e-tests matrix. The auth leg runs the Maven-owned checks inside mvnw verify -Pweb-e2e, so a React test or typecheck failure there can finish first and cancel the anonymous leg before its named steps report. The failure then only shows up under the e2e job name.
Restore what still holds after the named steps are added: frontend.yml builds with -DskipTests, so every Maven-owned check runs inside mvnw verify -Pweb-e2e on both legs, and the checks without a named step still surface under the e2e job name. In the React guidance, keep the build phase, the lint running only inside the e2e job, and the npm-audit remediation workflow running npm test.
kimyenac
force-pushed
the
ZEPPELIN-6566
branch
from
October 6, 2026 06:28
ae2694e to
9adb654
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Give the frontend unit checks named results in pull-request CI and run the React remote tests and typecheck through Maven.
projects/zeppelin-reactgainstypecheck(tsc --noEmit).test:reactandtypecheck:react. Both delegate withnpm --prefix projects/zeppelin-react, so the React project's working directory is unchanged.testphase gains two executions,npm test reactandnpm typecheck react. A failure names the execution in the Maven log, for exampleFailed to execute goal ... npm (npm typecheck react).frontend.ymlgains three steps on the anonymous leg ofrun-playwright-e2e-tests:Run Angular shell unit tests,Run React unit testsandTypecheck React.mvnw verify -Pweb-e2e, without a duplicate named result.exportFile.spec.tsspread aUint8Array, which failstsc --noEmitunder the React project's ES5 target. It now usesArray.from. This was the only typecheck error onmaster(943a3fb8d).fail-fast: falseon the e2e matrix:npm typecheck reactexecution failed first. Matrix fail-fast then cancelled the anonymous leg duringInstall application, soTypecheck Reactnever ran.fail-fast: false, both legs report (run).core.ymlalready usesfail-fast: falsefor its matrices.AGENTS.mdandprojects/zeppelin-react/AGENTS.mddescribe the new commands and CI steps. The parts that are still true are kept:verify -Pweb-e2eon both legs and surface under the e2e job name;npm test.Commits, continued from the
ZEPPELIN-6566-shell-react-cibranch invoidmatcha/zeppelinwith the author's agreement:7c709e5ac, the original commit unchanged: scripts, Maven executions, named steps, the TS2802 fix and the first docs update.038784611:fail-fast: falseon the e2e matrix.9adb65413: the docs corrections above.The verification below covers the combined result.
Cost: on the anonymous leg the shell tests, React tests and React typecheck now run twice, once as named steps and again in the Maven
testphase insideverify. Locally that is about 16 seconds in total: shell 8.2s, React 6.7s, typecheck 1.5s.What type of PR is it?
Improvement
Todos
typecheckto the React project, andtest:react/typecheck:reactto the frontend rootnpm test reactandnpm typecheck reactexecutionsWhat is the Jira issue?
ZEPPELIN-6566
How should this be tested?
Same pass count from every entry point. The React suite runs 15 files / 105 tests from each of:
npm testinprojects/zeppelin-reactnpm run test:reactat the frontend rootnpm test reactexecutionThe shell suite runs 211 tests.
./mvnw test -pl zeppelin-web-angularreports BUILD SUCCESS.Deliberate failures (all reverted). Each one was written to pass lint, so it fails in the targeted check and not earlier. The fork runs used throwaway branches, now deleted; the run pages remain.
npm run test:shellfails (1 failed / 211 passed)Run Angular shell unit testsfails (run)npm run test:reactfails; Maven fails at(npm test react)Run React unit testsfails (run)srcnpm run typecheck:reactfails; Maven fails at(npm typecheck react)Typecheck Reactfails, and the auth leg fails at Maven(npm typecheck react)(run)For the TypeScript error, the React webpack build uses
ts-loaderwithtranspileOnly: true. So the error does not failInstall applicationfirst, and it surfaces at the named step.Screenshots (if appropriate)
N/A.
Questions:
AGENTS.mdfiles are updated.🤖 Generated with Claude Code