Skip to content

Sync SDK with 2026-10-26 API fields - #33

Closed
superlog-bot[bot] wants to merge 1 commit into
mainfrom
fix/sync-sdk-with-2026-10-26-api-fields-4a6889ec
Closed

superlog-bot[bot] wants to merge 1 commit into
mainfrom
fix/sync-sdk-with-2026-10-26-api-fields-4a6889ec

Conversation

@superlog-bot

@superlog-bot superlog-bot Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Summary

Sync the TypeScript SDK with the API changes published on 2026-10-26:

  • Add Company.revenue_range to response schemas.
  • Add people.job_description to people search filters.
  • Add company.mx.provider to job search and TAM-by-jobs company filters.
  • Add regression coverage for the response field and request serialization.

API change: 2026-10-26 public API changelog — “Companies now return their revenue band in revenue_range”, “Filter people by job description with people.job_description”, and “Filter jobs by company mail provider with company.mx”.

Verification

  • pnpm test -- --run: 159 tests passed.
  • pnpm typecheck: passed.

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with one non-blocking improvement to the response test.

Fix All in Claude CodeFindings

  1. P2 Test misses typed field removal ▶
Fix with agent prompt
### Issue 1
test/models.test.ts:155
This assertion still passes if `revenue_range` is removed from `Company`. `blitzObject` preserves undeclared keys, so the fixture value survives without the schema entry. Add `expect(Object.keys(Company.shape)).toContain("revenue_range")` alongside the value check to catch that regression.

```suggestion
    expect(resp.company?.revenue_range).toBe("$10M-$50M");
    expect(Object.keys(Company.shape)).toContain("revenue_range");
```

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds the announced API fields to the TypeScript SDK.

  • Company responses expose a revenue band to TypeScript callers.
  • People and job searches accept two new filters.

Reviews (1) · Last reviewed commit: "Sync SDK with 2026-10-26 API fields" · Reviewed by Greptile

Comment thread test/models.test.ts
it("parses company enrichment", () => {
const resp = CompanyEnrichmentResponse.parse(data.COMPANY_ENRICHMENT);
expect(resp.company?.domain).toBe("google.com");
expect(resp.company?.revenue_range).toBe("$10M-$50M");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Test misses typed field removal

This assertion still passes if revenue_range is removed from Company. blitzObject preserves undeclared keys, so the fixture value survives without the schema entry. Add expect(Object.keys(Company.shape)).toContain("revenue_range") alongside the value check to catch that regression.

Suggested change
expect(resp.company?.revenue_range).toBe("$10M-$50M");
expect(resp.company?.revenue_range).toBe("$10M-$50M");
expect(Object.keys(Company.shape)).toContain("revenue_range");
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/models.test.ts
Line: 155

Comment:
**Test misses typed field removal**

This assertion still passes if `revenue_range` is removed from `Company`. `blitzObject` preserves undeclared keys, so the fixture value survives without the schema entry. Add `expect(Object.keys(Company.shape)).toContain("revenue_range")` alongside the value check to catch that regression.

```suggestion
    expect(resp.company?.revenue_range).toBe("$10M-$50M");
    expect(Object.keys(Company.shape)).toContain("revenue_range");
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Conductor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant