Repository navigation
Sync SDK with 2026-10-26 API fields - #33
Closed
superlog-bot[bot] wants to merge 1 commit into
Closed
superlog-bot[bot] wants to merge 1 commit into
superlog-bot[bot] wants to merge 1 commit into
Conversation
| it("parses company enrichment", () => { | ||
| const resp = CompanyEnrichmentResponse.parse(data.COMPANY_ENRICHMENT); | ||
| expect(resp.company?.domain).toBe("google.com"); | ||
| expect(resp.company?.revenue_range).toBe("$10M-$50M"); |
There was a problem hiding this comment.
Test misses typed field removal
This assertion still passes if revenue_range is removed from Company. blitzObject preserves undeclared keys, so the fixture value survives without the schema entry. Add expect(Object.keys(Company.shape)).toContain("revenue_range") alongside the value check to catch that regression.
Suggested change
| expect(resp.company?.revenue_range).toBe("$10M-$50M"); | |
| expect(resp.company?.revenue_range).toBe("$10M-$50M"); | |
| expect(Object.keys(Company.shape)).toContain("revenue_range"); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/models.test.ts
Line: 155
Comment:
**Test misses typed field removal**
This assertion still passes if `revenue_range` is removed from `Company`. `blitzObject` preserves undeclared keys, so the fixture value survives without the schema entry. Add `expect(Object.keys(Company.shape)).toContain("revenue_range")` alongside the value check to catch that regression.
```suggestion
expect(resp.company?.revenue_range).toBe("$10M-$50M");
expect(Object.keys(Company.shape)).toContain("revenue_range");
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync the TypeScript SDK with the API changes published on 2026-10-26:
Company.revenue_rangeto response schemas.people.job_descriptionto people search filters.company.mx.providerto job search and TAM-by-jobs company filters.API change: 2026-10-26 public API changelog — “Companies now return their revenue band in
revenue_range”, “Filter people by job description withpeople.job_description”, and “Filter jobs by company mail provider withcompany.mx”.Verification
pnpm test -- --run: 159 tests passed.pnpm typecheck: passed.The PR appears safe to merge, with one non-blocking improvement to the response test.
Fix with agent prompt
Summary
Adds the announced API fields to the TypeScript SDK.
Reviews (1) · Last reviewed commit: "Sync SDK with 2026-10-26 API fields" · Reviewed by Greptile