Repository navigation
ADFA-6251: Ignore output-panel drags that start above its visible edge - #2183
Daniel-ADFA wants to merge 1 commit into
Conversation
The editor bottom sheet is padded at the top by the status-bar height so its tabs clear the status bar when it expands to the top of the window. While collapsed, that transparent padding sits above the visible border, over the editor, and BottomSheetBehavior treats any drag inside the view's bounds as a drag on the sheet. A swipe that started up to a status bar's height above the border opened the panel. EditorBottomSheetBehavior drops a gesture whose ACTION_DOWN lands in the top padding, so the view underneath keeps it.
|
close #2078 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Gesture routing and layout integration app/src/main/java/com/itsaky/androidide/ui/EditorBottomSheetBehavior.kt, app/src/main/res/layout*/content_editor.xml |
The custom behavior returns false for gestures that start above the sheet’s top padding. Both editor layout variants use this behavior. Other gestures are delegated to the superclass. |
Gesture path tests app/src/test/java/com/itsaky/androidide/ui/EditorBottomSheetBehaviorTest.kt |
Robolectric tests verify that a drag starting in the top padding leaves the sheet collapsed and delivers move events to the editor without cancellation. A drag starting on the visible sheet moves it into the dragging state. |
Priority:
Estimated code review effort: 2 (Simple) | ~15 minutes
Change: Bug fix · Severity of issue fixed: Low
Suggested reviewers: hal-eisen-adfa, jatezzz
Merge Risk: 
616e7
-
Drags starting above the visible panel border are excluded by the new behavior. No actionable merge-blocking risk remains.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title clearly and concisely describes the main change: preventing output-panel drags that start above the visible edge. Description check The description directly explains the reported issue, the implemented behavior, affected layouts, testing scope, and linked issue. Linked Issues check Issue #2078requires swipe detection to start at the visible output-panel border.EditorBottomSheetBehaviorrecords the initial touch and bypassesBottomSheetBehaviorwhen the touch starts in the …Out of Scope Changes check The changes are limited to the custom bottom-sheet behavior, its use in the two editor layouts, and focused automated tests. Each change supports issue #2078.Full details: Linked Issues check
-
Explanation
Issue
#2078requires swipe detection to start at the visible output-panel border.EditorBottomSheetBehaviorrecords the initial touch and bypassesBottomSheetBehaviorwhen the touch starts in the sheet's top padding. Bothcontent_editor.xmllayouts use the behavior.EditorBottomSheetBehaviorTestverifies that padding drags remain collapsed and that visible-panel drags still move the sheet.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit taps the sheet, then starts to glide,
The padded edge lets editor events ride.
The visible top can move the panel high,
Two paths are checked as pixels hurry by.
I nibble code, then hop beneath the sky.
Comment @coderabbitai help to get the list of available commands.
ADFA-6251
Fixes #2078. Swiping up from just above the collapsed output panel opened it.
The sheet is padded at the top by the status-bar height so its tabs clear the status bar when expanded. Collapsed, that transparent strip (52dp on a Pixel) sits over the editor, and
BottomSheetBehaviordrags the sheet for any touch inside its bounds.EditorBottomSheetBehaviorignores gestures that start in that padding; bothcontent_editor.xmllayouts use it.Tested on an arm64 emulator at font scale 1.0 and 2.0: a drag from the strip or 15px above the border leaves the sheet collapsed and goes to the editor; a drag from the header still opens it; a drag down from the expanded tabs still closes it.
EditorBottomSheetBehaviorTestfails against the stock behavior.