Repository navigation
K2GO-510 fix(clone): name the shared APK after the ABIs it carries - #701
Merged
Merged
Conversation
The QR download and the share sheet read the APK's lib/ folders (universal, arm64-v8a, armeabi-v7a, noarch) instead of the phone's width. The share sheet no longer sends the file as "base.apk".
The name lookup now falls back to "unknown" on any read error and ignores bare lib/<abi>/ directory entries. The share sheet reuses the name of the running APK server. Design map lists sync/data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone "Send app" names the shared file after the native ABIs inside the APK (
lib/<abi>/), not after the width of the sending phone. This restores the ADFA-4540 rule (ApkShareName.archLabel), which the legacy UI removal left unused.universal,arm64-v8a,armeabi-v7a, ornoarch(no native libs).unknownand the share continues.base.apk(FileProviderdisplay name).sync/data/ApkAbiReader(JDK zip) with JVM tests. Design map updated.Verification:
syncunit tests pass (15). The reader on the real universal, v7a and v8a debug APKs givesuniversal,armeabi-v7aandarm64-v8a.