Repository navigation
ADFA-6692 | Add Build Animation plugin - #145
Open
jimturner-adfa wants to merge 2 commits into
Open
jimturner-adfa wants to merge 2 commits into
jimturner-adfa wants to merge 2 commits into
Conversation
A toolbar icon that animates while Gradle works: a wrench rocks during a build or sync, then a tick or a cross shows the result for 5 s. Built on the host's dynamic toolbar icon (ToolbarAction.iconProvider plus IdeUIService.refreshToolbarActions), which starts animated drawables itself, so the plugin draws no view of its own. The icon is greyed out when idle rather than hidden. The editor toolbar is end-aligned, so showing or hiding an icon shifts every built-in button, and Stop would move out from under the finger that tapped Run. The 5 s result window outlasts the host's own "Build successful" flashbar, which covers the toolbar for about 2 s. BuildAnimationState is a plain state machine behind a Scheduler seam, unit-tested on the JVM. Requires CoGo 26.29, the first release with dynamic toolbar icons. No permissions. Co-Authored-By: Claude Opus 5.5 <[email protected]>
- 6.6: restructure build-animation.html into the required Executive Overview, Core Functionality, Technical Architecture, Usage and Key Benefits sections (Limits kept as an extra). - 6.1 / manifest: declare plugin.max_ide_version 26.99 so the manifest states a range, matching Icons-Repository. - 6.2: dispose() now runs the same idempotent teardown as deactivate(), so the build listener and pending timer cannot outlive the plugin if the host disposes without deactivating. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-6692
Adds Build Animation, a plugin that puts an animated icon at the end of the editor toolbar while Gradle works: a wrench rocks during a build or sync, then a tick or a cross shows the result for 5 s. Idle, it is a greyed-out wrench. Our own vector art; no permissions.
How
ToolbarAction.iconProvider+IdeUIService.refreshToolbarActions()); the host starts animated drawables itself (ProjectActionsToolbar.kt:57in CoGo). No custom view, overlay or inset handling.BuildAnimationStateis a plain state machine behind aSchedulerseam, unit-tested on the JVM.iconProvider,refreshToolbarActions()and the host's auto-start of animated icons.Design changes found on device
DURATION_SHORT) and hid most of a 3 s tick.Verification
assemblePluginfrom a clean tree: no warnings; provenancerevision_source=git, not dirty.testDebugUnitTest: 6/6. The new-build-during-result test fails without the cancel-on-start fix (expected:<BUILDING> but was:<IDLE>).addons check: 0 problems. Run fromtools/addons/srcon the system Python with jsonschema 4.10, not viauv.plugin-review: the first pass found 6.6 (missing required HTML sections), 6.1 (no max IDE version) and 6.2 (emptydispose()). All three are fixed in the second commit.C-d-0929-1057): install, idle greyed wrench, wrench animating during sync, tick on success, cross on cancel, and no button shift.Not verified:
documentation.dbis empty (no such table: Tooltips), so no plugin can register tooltips there.onBuildFailedpath) and animations turned off.Known limits
Seen in passing, not changed here
n/a. The host looks up toolbar tooltips as<pluginId>.<actionId>(PluginToolbarActionItem.kt:81-82), but STT registers the barestt_voice_to_code.🤖 Generated with Claude Code