Repository navigation
fix: consistent and private live node backups - #565
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 89.39% 89.38% -0.02%
==========================================
Files 1487 1490 +3
Lines 618020 618557 +537
==========================================
+ Hits 552487 552900 +413
- Misses 65533 65657 +124 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
St4NNi
force-pushed
the
fix/live-backup-safety
branch
from
November 4, 2026 06:32
b646f51 to
90b7e88
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to the live backup commands. A backup now reads the node, document sync and metadata databases at one instant. Backup files are readable by their owner only. A restore never leaves a half-built directory behind, and the doctor builds again on platforms without Unix sockets. Blob contents stay outside the backup. A restored node therefore checks every bucket and lists versions whose blob is missing.
Changes
<target>.partialand rename it into place only after the whole file passed its checks; a failed restore removes the partial directoryGET /data/buckets/{bucket}/storage/checklists versions whose blob is missingBLOB_ROOTand other storage backends) are not part of a backuparunaandaruna-doctorbuild on Windows; therearuna-doctor backupreports that live backups are unsupported, andrestoreworksRelates to #556