Skip to content

fix: build the library on macOS and Windows - #38

Open
St4NNi wants to merge 6 commits into
mainfrom
fix/portable-library
Open

St4NNi wants to merge 6 commits into
mainfrom
fix/portable-library

Conversation

@St4NNi

@St4NNi St4NNi commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Description

pithos_lib 0.8.0 compiles its Linux-only fs module on every platform, so the library does not build on macOS or Windows, even without default features. Aruna needs the archive, crypto and source modules on all three platforms.

The dependency checks also failed on advisories in ctutils, zstd and zip 8. zip 8 comes from ro-crate-rs, whose releases up to 0.7.0 all require zip 8. Until ro-crate-rs publishes a zip 9 release, pithos_lib uses ro-crate-rs main by git, so it cannot be published to crates.io from this state.

Changes

  • Compile the fs module only on Linux, as documented in AGENTS.md.
  • Read FileSource ranges with the Windows positional read on Windows and read_at on Unix.
  • Bump pithos_lib, pithos and pithos_pyo3 to 0.8.1.
  • Update ctutils, tokio and zstd for their advisories.
  • Use ro-crate-rs main (zip 9) and zip 9 for the RO-Crate adapter, and allow that git source in deny.toml.
  • Mark the raw ZIP test fixture entries as made by Unix, since zip 9 only reads Unix modes from Unix entries.

Relates to arunaengine/aruna#558

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.46%. Comparing base (ed25901) to head (877025c).

Files with missing lines Patch % Lines
crates/pithos_lib/src/source.rs 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   89.48%   89.46%   -0.03%     
==========================================
  Files          34       34              
  Lines       12902    12905       +3     
==========================================
  Hits        11545    11545              
- Misses       1357     1360       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@St4NNi

St4NNi commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

I will most likely keep that PR open until ro-crate-rs has a new release, since we cannot release a library with a git dependency!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant