Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 89.48% 89.46% -0.03%
==========================================
Files 34 34
Lines 12902 12905 +3
==========================================
Hits 11545 11545
- Misses 1357 1360 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
I will most likely keep that PR open until ro-crate-rs has a new release, since we cannot release a library with a git dependency! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pithos_lib 0.8.0 compiles its Linux-only
fsmodule on every platform, so the library does not build on macOS or Windows, even without default features. Aruna needs the archive, crypto and source modules on all three platforms.The dependency checks also failed on advisories in ctutils, zstd and zip 8. zip 8 comes from ro-crate-rs, whose releases up to 0.7.0 all require zip 8. Until ro-crate-rs publishes a zip 9 release, pithos_lib uses ro-crate-rs main by git, so it cannot be published to crates.io from this state.
Changes
fsmodule only on Linux, as documented in AGENTS.md.FileSourceranges with the Windows positional read on Windows andread_aton Unix.pithos_lib,pithosandpithos_pyo3to 0.8.1.Relates to arunaengine/aruna#558