Repository navigation
fix(signer): sign every value of repeated query parameters - #5878
Merged
dreamorosi merged 1 commit intoOct 30, 2026
Merged
dreamorosi merged 1 commit into
dreamorosi merged 1 commit into
Conversation
dreamorosi
approved these changes
Oct 30, 2026
dreamorosi
left a comment
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for filing the issue and for the PR!
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SigV4Signerkept only the last value of a repeated query parameter when building the canonical request, so?tag=red&tag=bluewas signed as?tag=bluewhile the request still carried both values. API Gateway then rejected the request with a signature mismatch. The signer now passes all values to@smithy/signature-v4.Changes
SigV4Signer: a single value stays astring, a repeated parameter becomes astring[]?tag=red&foo=bar&tag=blueand compares theauthorizationheader withSignatureV4signingquery: { foo: 'bar', tag: ['red', 'blue'] }directlyIssue number: closes #5870
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
🤖 Generated with Claude Code