Repository navigation
fix(parser): accept Transfer Family events without password and with IPv6 source IP - #5880
Merged
dreamorosi merged 2 commits intoOct 31, 2026
Conversation
dreamorosi
approved these changes
Oct 31, 2026
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this PR as well!
dreamorosi
enabled auto-merge (squash)
October 31, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Two fixes to
TransferFamilySchema:passwordis now optional. For SSH public key authentication, Transfer Family invokes the custom identity provider without apassword, and the AWS example functions check!event.passwordfor that case. Parsing such an event previously failed with aZodError. This matches Powertools for AWS Lambda (Python), which has modeled the field as optional since feat(parser): add AWS Transfer Family model powertools-lambda-python#5906.sourceIpaccepts IPv6. Transfer Family has supported IPv6 endpoints since June 2025, but the field wasz.ipv4(), so logins from IPv6 clients failed to parse, password logins included. It now usesz.union([z.ipv4(), z.ipv6()]), assourceIpalready does inpackages/parser/src/schemas/api-gatewayv2.ts. Python usesIPvAnyAddressfor this field.TransferFamilyEventstays inferred from the schema, so there is no separate type change. Added the two tests requested in the issue to the existingdescribeblock inpackages/parser/tests/unit/schema/transfer-family.test.ts. Both fail onmainand pass with this change.npm run test:unit:coverageandnpm run test:unit:typesinpackages/parserpass, with 100% coverage kept.Issue number: closes #5869
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.