Skip to content

[CI] Fix MSRV failure due to async-lock (or bump MSRV to 1.84 to get MSRV-aware resolver) #1077

Closed
#1078
Closed
[CI] Fix MSRV failure due to async-lock (or bump MSRV to 1.84 to get MSRV-aware resolver)#1077
#1078

Description

@jlizen
jlizen
opened on Dec 26, 2025
error: rustc 1.82.0 is not supported by the following package:
  [email protected] requires rustc 1.85
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.82.0

example: https://github.com/aws/aws-lambda-rust-runtime/actions/runs/20501347843/job/58977029559?pr=1067

Looks like we implicitly picked up a newer version that bumped MSRV: smol-rs/async-lock#103

I thought we were using the MSRV-aware resolver...

Activity

  1. jlizen commented on Dec 26, 2025

    @jlizen
    jlizen
    on Dec 26, 2025
    MemberAuthor

    Oh, MSRV-aware resolver is only in 1.84...

  2. jlizen
    changed the title [-][CI] Fix MSRV failure due to async-lock[/-] [+][CI] Fix MSRV failure due to async-lock (or bump MSRV to 1.84 to get MSRV-aware resolver)[/+] on Dec 26, 2025

  3. jlizen commented on Dec 26, 2025

    @jlizen
    jlizen
    on Dec 26, 2025
    MemberAuthor

    Related: #986 (setting policy for rolling MSRV forward)

  4. jlizen commented on Dec 26, 2025

    @jlizen
    jlizen
    on Dec 26, 2025
    MemberAuthor

    Reaching out to other maintainers to discuss bumping to 1.84, even in absence of a clear MSRV policy, as 1.84 is ~11 months old at this point. That would address this class of issues in the future, once we did.

    Will hold off on pinning this dependency in the interim.

  5. jlizen
    closed this as completedin #1078on Dec 27, 2025

  6. github-actions commented on Dec 27, 2025

    @github-actions
    github-actionsbot
    on Dec 27, 2025 – with GitHub Actions

    This issue is now closed. Comments on closed issues are hard for our team to see.
    If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions