Skip to content

feat(webkit): add TabView underline kind and fix axe a11y findings - #1169

Closed
gabriel-lisboa-azion wants to merge 16 commits into
mainfrom
fix/webkit-a11y-axe-findings
Closed

gabriel-lisboa-azion wants to merge 16 commits into
mainfrom
fix/webkit-a11y-axe-findings

Conversation

@gabriel-lisboa-azion

@gabriel-lisboa-azion gabriel-lisboa-azion commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Fixes the axe findings across webkit: Button forwards aria-label and other native attributes to its root (ENG-49967), Item lists announce their members as listitem (ENG-49969), and Popover.Trigger puts its ARIA on the focusable control instead of a roleless span (ENG-49968).
  • Raises color contrast to WCAG AA: code syntax tokens in light mode (ENG-49971), black text on the primary fill in dark mode (ENG-49970), feedback tokens, Tag, Message links, Link (hover underline replaces the hover surface) and StatusIndicator (pulsing dot replaces the spinner).
  • Adds a non-breaking underline kind to TabView, and sizes the InputText, InputPassword and TableSearch slot icons with the label type.

How to test

  1. pnpm webkit:test: all suites pass, including the new TabView, Item, Popover and Button cases.
  2. pnpm storybook:dev, open Components/Navigation/TabView → Underline: the active tab gets a bar on a hairline baseline and follows the selection.
  3. Components/Primitives/Inputs/FieldText → Icons: the trailing icon is pi-verified (a status glyph) instead of a pi-times that looked like a clear button and did nothing.
  4. Open the Accessibility panel on Button, Item (WithGroup), Popover, Tag and Message in both themes: no axe violations.

Notes

  • No breaking changes. Squash title is feat (TabView kind), so release-please cuts a minor for @aziontech/webkit and, since the PR also touches theme files, for @aziontech/theme.
  • The FieldText/InputText type, autocomplete and spellcheck props (ENG-49936) were taken out of this PR (last commit): feat(webkit)!: [ENG-50003] make WebKit ready for AI agents #1170 delivers them.
  • Visual baselines are regenerated in CI on this branch (theme colors, Tag, Link, StatusIndicator, TabView).
  • Issues: ENG-49967, ENG-49968, ENG-49969, ENG-49970, ENG-49971.

Removes the type, autocomplete and spellcheck props from FieldText and InputText (ENG-49936), with their tests, specs, story argTypes and catalog entries. #1170 ships the same API.
@gabriel-lisboa-azion gabriel-lisboa-azion changed the title feat(webkit): [ENG-49936] add FieldText native hints, TabView underline kind and a11y fixes feat(webkit): add TabView underline kind and fix axe a11y findings Nov 10, 2026
rafael-umann-azion pushed a commit that referenced this pull request Nov 11, 2026
…atterns, a11y harness

- docs/reviews/m2.9-inventory.md: the design sample, Console Kit and Cloudscape against WebKit,
  one row per piece (equivalent, decision, size, work package), 13 work packages, the a11y
  backlog and the plan for removing the sample
- platform/states/form-error: the sample's /forms/error-validation as its own block (InSync,
  Rejected, Reloading, Reloaded, moved out of form-validation); rule in webkit-errors and
  webkit-form; v6 block map updated
- platform/states/async-submit: progress toast description from the sample; Edit and Redeploy
  (never View deployments) written into webkit-ui-states, webkit-errors and the block guidelines
- a11y harness: axe (WCAG 2.1 A/AA, contrast) over every block and example in light, dark and
  forced-colors with reduced motion (emulateMedia browser command); a11y-known.json only shrinks
- PR #1169 port: contrast tokens, Item listitem roles, Link hover underline, Alert link colour,
  Tag primary fill; two size budgets raised and justified
- ROADMAP: M2.9 phase 1 paragraph, M2.10 rows 2-5

Co-Authored-By: Claude Opus 5.5 <[email protected]>
rafael-umann-azion pushed a commit that referenced this pull request Nov 11, 2026
rafael-umann-azion pushed a commit that referenced this pull request Nov 13, 2026
The console's Owner role pill is the brand orange as a tint (orange text on --primary-mask),
the look of the design sample's Tag primary before PR #1169 made primary a solid fill for
contrast. Builders had no severity for it and used accent or danger. highlight adds it back as
its own value: --primary-mask surface, text --text-primary mixed 80/20 with --text-default,
which measures 5.1:1 or more on surface and canvas in both themes (--text-primary alone is
4.4:1 on the light canvas). The spec now says which severity fits which value (Inactive is
secondary, never danger), fixes the stale 'severity via kind' wording, and the Types example
shows highlight.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants