Repository navigation
feat(webkit): add TabView underline kind and fix axe a11y findings - #1169
Closed
gabriel-lisboa-azion wants to merge 16 commits into
Closed
gabriel-lisboa-azion wants to merge 16 commits into
gabriel-lisboa-azion wants to merge 16 commits into
Conversation
gabriel-lisboa-azion
requested review from
isaque-bock-azion and
robson-junior-azion
November 10, 2026 15:25
Removes the type, autocomplete and spellcheck props from FieldText and InputText (ENG-49936), with their tests, specs, story argTypes and catalog entries. #1170 ships the same API.
rafael-umann-azion
pushed a commit
that referenced
this pull request
Nov 11, 2026
…atterns, a11y harness - docs/reviews/m2.9-inventory.md: the design sample, Console Kit and Cloudscape against WebKit, one row per piece (equivalent, decision, size, work package), 13 work packages, the a11y backlog and the plan for removing the sample - platform/states/form-error: the sample's /forms/error-validation as its own block (InSync, Rejected, Reloading, Reloaded, moved out of form-validation); rule in webkit-errors and webkit-form; v6 block map updated - platform/states/async-submit: progress toast description from the sample; Edit and Redeploy (never View deployments) written into webkit-ui-states, webkit-errors and the block guidelines - a11y harness: axe (WCAG 2.1 A/AA, contrast) over every block and example in light, dark and forced-colors with reduced motion (emulateMedia browser command); a11y-known.json only shrinks - PR #1169 port: contrast tokens, Item listitem roles, Link hover underline, Alert link colour, Tag primary fill; two size budgets raised and justified - ROADMAP: M2.9 phase 1 paragraph, M2.10 rows 2-5 Co-Authored-By: Claude Opus 5.5 <[email protected]>
rafael-umann-azion
pushed a commit
that referenced
this pull request
Nov 11, 2026
… a11y harness, #1169 port) Co-Authored-By: Claude Opus 5.5 <[email protected]>
rafael-umann-azion
pushed a commit
that referenced
this pull request
Nov 13, 2026
The console's Owner role pill is the brand orange as a tint (orange text on --primary-mask), the look of the design sample's Tag primary before PR #1169 made primary a solid fill for contrast. Builders had no severity for it and used accent or danger. highlight adds it back as its own value: --primary-mask surface, text --text-primary mixed 80/20 with --text-default, which measures 5.1:1 or more on surface and canvas in both themes (--text-primary alone is 4.4:1 on the light canvas). The spec now says which severity fits which value (Inactive is secondary, never danger), fixes the stale 'severity via kind' wording, and the Types example shows highlight. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-labeland other native attributes to its root (ENG-49967), Item lists announce their members aslistitem(ENG-49969), and Popover.Trigger puts its ARIA on the focusable control instead of a roleless span (ENG-49968).underlinekind to TabView, and sizes the InputText, InputPassword and TableSearch slot icons with the label type.How to test
pnpm webkit:test: all suites pass, including the new TabView, Item, Popover and Button cases.pnpm storybook:dev, open Components/Navigation/TabView → Underline: the active tab gets a bar on a hairline baseline and follows the selection.pi-verified(a status glyph) instead of api-timesthat looked like a clear button and did nothing.Notes
feat(TabViewkind), so release-please cuts a minor for@aziontech/webkitand, since the PR also touches theme files, for@aziontech/theme.type,autocompleteandspellcheckprops (ENG-49936) were taken out of this PR (last commit): feat(webkit)!: [ENG-50003] make WebKit ready for AI agents #1170 delivers them.