You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Minimal version of #1082 - just add the __init__.py files - #1087
$ bazel shutdown
$ bazel build //...
Starting local Bazel server (9.3.0) and connecting to it...
DEBUG: .../rules_python+/python/private/py_executable.bzl:1595:14:
======================================================================
WARNING: Target @@rules_pkg+//pkg/private/zip:build_zip is using implicit __init__.py creation.
This diabolic behavior is deprecated and will be disabled by default in a
future release.
See https://github.com/bazel-contrib/rules_python/issues/2945
Ensure all __init__.py files are explicitly created and
added to the srcs or deps of your targets.
Disable implicit creation for your module in MODULE.bazel:
rules_python_config = use_extension("@rules_python//python/extensions:config.bzl", "config")
rules_python_config.explicit_init_py(default = True)
Or for a specific target by setting:
legacy_create_init = 0
Or globally with the following Bazel flag:
--incompatible_default_to_explicit_init_py
======================================================================
DEBUG: .../rules_python+/python/private/py_executable.bzl:1595:14:
======================================================================
WARNING: Target @@rules_pkg+//pkg/private/tar:build_tar is using implicit __init__.py creation.
This diabolic behavior is deprecated and will be disabled by default in a
future release.
See https://github.com/bazel-contrib/rules_python/issues/2945
Ensure all __init__.py files are explicitly created and
added to the srcs or deps of your targets.
Disable implicit creation for your module in MODULE.bazel:
rules_python_config = use_extension("@rules_python//python/extensions:config.bzl", "config")
rules_python_config.explicit_init_py(default = True)
Or for a specific target by setting:
legacy_create_init = 0
Or globally with the following Bazel flag:
--incompatible_default_to_explicit_init_py
======================================================================
DEBUG: .../rules_python+/python/private/py_executable.bzl:1595:14:
======================================================================
WARNING: Target @@rules_pkg+//pkg/private/deb:make_deb is using implicit __init__.py creation.
This diabolic behavior is deprecated and will be disabled by default in a
future release.
See https://github.com/bazel-contrib/rules_python/issues/2945
Ensure all __init__.py files are explicitly created and
added to the srcs or deps of your targets.
Disable implicit creation for your module in MODULE.bazel:
rules_python_config = use_extension("@rules_python//python/extensions:config.bzl", "config")
rules_python_config.explicit_init_py(default = True)
Or for a specific target by setting:
legacy_create_init = 0
Or globally with the following Bazel flag:
--incompatible_default_to_explicit_init_py
======================================================================
INFO: Analyzed 10 targets (103 packages loaded, 3269 targets configured).
INFO: Found 10 targets...
INFO: Elapsed time: 3.321s, Critical Path: 0.06s
INFO: 1 process: 82 action cache hit, 1 internal.
INFO: Build completed successfully, 1 total action
Sure, if you use a newer rules_python, you'll see the warnings,
But that means it's under the control of the users MODULE.bazel file.
They could add the recommend stanza
Sure, if you use a newer rules_python, you'll see the warnings, But that means it's under the control of the users MODULE.bazel file. They could add the recommend stanza
If you check my MODULE.bazel example it has those two lines. Please try it out. The rules only apply to the users own usage of rules_python, not the internal usage of rules_pkg
If you check my MODULE.bazel example it has those two lines. Please try it out. The rules only apply to the users own usage of rules_python, not the internal usage of rules_pkg
I see what you are getting at. That's broken in rules_python, because the outer user should be able to control behaviors all the way down. So this PR is partial, but not sufficient for all users.
What I don't want to do, though, is force an update to the minimal rules_python we are currently using.
I'll talk to @rickeylev about this at some point. I wonder what they are planning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add init.py files to modules. Working towards #1081