[chukwudiikeh]

Fixes #352

env_logger::init() only shows error messages when RUST_LOG is unset, so every warn! in bdk-cli was hidden from users, including the mainnet notice.

This PR defaults the log filter to warn while keeping RUST_LOG as an override (RUST_LOG=error hides warnings again), and adds tests for both cases. The default covers all crates as proposed in the issue; limiting it to bdk_cli=warn is a one-word change if preferred.

Fixed

Warnings, including the mainnet notice, are now shown by default without setting RUST_LOG.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.46%. Comparing base (79b2b83) to head (3f6b023).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files          23       23           
  Lines        3989     3989           
=======================================
  Hits         2452     2452           
  Misses       1537     1537           

Flag	Coverage Δ
rust	61.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vadim-anfv]

tACK 33808be

Checked both cases on the branch: cargo run -- --network=bitcoin wallets prints the mainnet warning with no environment variable set, and RUST_LOG=error hides it again.

On the open question in the description: I would keep the global default rather than bdk_cli=warn. A warning from rustls or rusqlite is worth seeing just as much as one from bdk-cli, and narrowing it later is a one-word change if dependencies turn out to be noisy. @tvpeter how do you see this one, global or bdk-cli only?

One nit: worth a line in [Unreleased] in CHANGELOG.md, since this changes what users see on a plain run.

[chukwudiikeh]

Thanks for testing, @vadim-anfv. Added the CHANGELOG entry under [Unreleased].

[vadim-anfv]

ACK 3f6b023

[tvpeter]

On the open question in the description: I would keep the global default rather than bdk_cli=warn. A warning from rustls or rusqlite is worth seeing just as much as one from bdk-cli, and narrowing it later is a one-word change if dependencies turn out to be noisy. @tvpeter how do you see this one, global or bdk-cli only?

I agree that having it global might provide useful upstream warnings to users.

[tvpeter]

ACK 3f6b023