Skip to content

feat: Migrate transaction building from TxBuilder to Wallet::create_psbt - #354

Draft
sdmg15 wants to merge 2 commits into
bitcoindevkit:masterfrom
sdmg15:feat/replace-txbuilder-with-create-psbt
Draft

sdmg15 wants to merge 2 commits into
bitcoindevkit:masterfrom
sdmg15:feat/replace-txbuilder-with-create-psbt

Conversation

@sdmg15

@sdmg15 sdmg15 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR is about moving bdk-cli to Wallet::create_psbt from bdk_wallet 3.2.0.

Closes #338

Notes to the reviewers

Thanks to the detailed issue description by vadim the changes will go incrementally following this structure:

1 - Updates of CreateTxCommand in src/handlers/offline.rs
2 - Updates of CreateSpTxCommand in src/handlers/offline.rs
3- Updates of BumpFeeCommand in src/handlers/offline.rs, the only one using build_fee_bump
4- Updates of CreateDnsTxCommand in src/handlers/dns/mod.rs
5- Updates of PayjoinManager::send_payjoin in src/handlers/payjoin/mod.rs

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@sdmg15
sdmg15 force-pushed the feat/replace-txbuilder-with-create-psbt branch 2 times, most recently from 677b6ea to 2521e8f Compare October 19, 2026 16:06
@sdmg15
sdmg15 force-pushed the feat/replace-txbuilder-with-create-psbt branch from 2521e8f to f22211f Compare October 19, 2026 16:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Migrate transaction building from TxBuilder to Wallet::create_psbt

1 participant