Repository navigation
Change unused address output to list - #355
Open
emma31-dev wants to merge 2 commits into
Open
emma31-dev wants to merge 2 commits into
emma31-dev wants to merge 2 commits into
Conversation
Return all unused external addresses instead of only the next one, wrapping results in ListResult.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates the
UnusedAddressCommandto return all unused external addresses rather than only the next one. Previously, the command calledWallet::next_unused_addressand returned a single AddressResult, which could be misleading if multiple addresses had already been revealed but not yet used. The output type is nowListResult<AddressResult>, populated by iterating overWallet::list_unused_addresseson the external keychain. This gives users a complete picture of all addresses awaiting use, making the command more useful for wallet inspection and reducing the risk of address reuse caused by incomplete visibility. This pr solves issue #349 opened by me.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing