Repository navigation
Conversation
Refs bitcoindevkit#2343 Signed-off-by: Hassan Rehman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #2343
Documents that Esplora
syncandfull_scanadd server-reported previous outputs as floating txouts without checking them against the full parent transaction. Explains how fee and sent/received numbers can depend on those values, or on scripts a server reports, when the parent transaction is absent, including inputs that belong to other parties. Adds a trust-assumptions section to the Esplora README and links thesyncandfull_scandocs on both the blocking and async extension traits to it.This changes documentation only. It does not add parent-transaction verification.
Notes to the reviewers
Doc-only, 33 added lines in 3 files. I used "Refs" because I am not sure whether you also want the behaviour changed (verifying parents) rather than documented. Happy to adjust the wording or scope to whatever you prefer on #2343.
Behaviour described in the docs is checked by a separate local harness: a forged floating txout value changes the computed fee, and fetching the full actual parent transaction restores the correct fee.
Changelog notice
Documented the trust assumptions of server-reported previous outputs in
bdk_esplora.Checklists
All Submissions:
Bugfixes: