Repository navigation
PM-39367: bug: When the billing API 404s, the 'Plan' row should be hidden from the UI - #7546
Draft
david-livefront wants to merge 1 commit into
Draft
david-livefront wants to merge 1 commit into
david-livefront wants to merge 1 commit into
Conversation
github-actions
Bot
added
app:password-manager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7546 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 896 896
Lines 65792 65798 +6
Branches 9407 9411 +4
=======================================
+ Hits 57121 57127 +6
Misses 5187 5187
Partials 3484 3484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
david-livefront
force-pushed
the
PM-39367-no-subscription
branch
2 times, most recently
from
October 30, 2026 20:45
e5ab1e1 to
1cca0c5
Compare
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| } | ||
| // The Plan Row is hidden if the user has premium but does not have | ||
| // a subscription or the premium status was granted by an organization. | ||
| !((hasPremium && !hasSubscription) || isOrgOnlyPremium) |
There was a problem hiding this comment.
The hasPremium and isOrgOnlyPremium checks combine && and || in one condition, making the eligibility logic harder to parse.
Suggested change
| !((hasPremium && !hasSubscription) || isOrgOnlyPremium) | |
| val hasIneligiblePremium = hasPremium && !hasSubscription | |
| !(hasIneligiblePremium || isOrgOnlyPremium) |
Details
✨ AI Reasoning
The condition combines a conjunction and a disjunction, requiring the reader to track how hasPremium, hasSubscription, and isOrgOnlyPremium relate. This creates avoidable precedence and grouping complexity in the eligibility expression.
Reply on this comment to give feedback or ignore the issue.
More info
david-livefront
force-pushed
the
PM-39367-no-subscription
branch
from
October 30, 2026 20:49
1cca0c5 to
4d24a15
Compare
david-livefront
force-pushed
the
PM-39367-no-subscription
branch
from
October 30, 2026 20:56
4d24a15 to
5ae4694
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-39367
📔 Objective
This PR updates the
isPlanRowEligibleFlowto emit false if no subscription is found.