Repository navigation
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR removes the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7548 +/- ##
==========================================
- Coverage 86.82% 86.81% -0.01%
==========================================
Files 896 896
Lines 65792 65779 -13
Branches 9407 9406 -1
==========================================
- Hits 57121 57108 -13
Misses 5187 5187
Partials 3484 3484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-37634
Related Step 1 PRs for
fedramp-gov-region:📔 Objective
Step 1 of the Feature Flags Lifecycle unwind for
fedramp-gov-region(FlagKey.FedRamp). The flag branch maintained istrue, so the FedRAMP region is always offered in the landing screen environment selector.This change was not built or tested locally. It relies on this PR's CI checks for validation.
Files touched
core/.../model/FlagKey.ktFedRampdata object and itsactivePasswordManagerFlagsentrycore/.../model/FlagKeyTest.ktFedRampapp/.../landing/LandingViewModel.ktFeatureFlagManagerdependency, theisFedRampEnabledstate, theFedRampFeatureUpdatedaction and handler, and the FED_RAMP filter inenvironmentTypeOptionsapp/.../landing/LandingViewModelTest.ktapp/.../landing/LandingScreenTest.ktisFedRampEnabledfromDEFAULT_STATEui/.../debug/FeatureFlagListItems.ktui/.../values/strings_non_localized.xmlfed_rampstring, which only the debug label used60-second reviewer checklist
git grep fedramp-gov-regionandgit grep FlagKey.FedRampreturn nothing.Environment.Prod.FedRampandEnvironment.Type.FED_RAMPare still present. They model the real environment, not the flag.