Skip to content

[PM-37634] Remove fedramp-gov-region feature flag (step 1) - #7548

Draft
trmartin4 wants to merge 1 commit into
mainfrom
flag-cleanup/fedramp-gov-region-step-1
Draft

trmartin4 wants to merge 1 commit into
mainfrom
flag-cleanup/fedramp-gov-region-step-1

Conversation

@trmartin4

@trmartin4 trmartin4 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37634

Related Step 1 PRs for fedramp-gov-region:

📔 Objective

Step 1 of the Feature Flags Lifecycle unwind for fedramp-gov-region (FlagKey.FedRamp). The flag branch maintained is true, so the FedRAMP region is always offered in the landing screen environment selector.

This change was not built or tested locally. It relies on this PR's CI checks for validation.

Files touched

File Change
core/.../model/FlagKey.kt Removed the FedRamp data object and its activePasswordManagerFlags entry
core/.../model/FlagKeyTest.kt Removed the key name and default value assertions for FedRamp
app/.../landing/LandingViewModel.kt Removed the FeatureFlagManager dependency, the isFedRampEnabled state, the FedRampFeatureUpdated action and handler, and the FED_RAMP filter in environmentTypeOptions
app/.../landing/LandingViewModelTest.kt Removed the flag mocks, the constructor argument, and the flag-change test
app/.../landing/LandingScreenTest.kt Removed isFedRampEnabled from DEFAULT_STATE
ui/.../debug/FeatureFlagListItems.kt Removed the debug menu entries for the flag
ui/.../values/strings_non_localized.xml Removed the fed_ramp string, which only the debug label used

60-second reviewer checklist

  • git grep fedramp-gov-region and git grep FlagKey.FedRamp return nothing.
  • Environment.Prod.FedRamp and Environment.Type.FED_RAMP are still present. They model the real environment, not the flag.
  • The test that exercised the flag-off branch is deleted, not skipped.
  • CI is green, since nothing was run locally.

@trmartin4 trmartin4 added the ai-review Request a Claude code review label Oct 30, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt labels Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes the fedramp-gov-region feature flag (FlagKey.FedRamp) and keeps the flag-on behavior, so the landing screen environment selector now always includes Environment.Type.FED_RAMP. The removal is complete. Nothing in the tree still references FlagKey.FedRamp, the fedramp-gov-region key, isFedRampEnabled, FedRampFeatureUpdated, or the fed_ramp debug string, and Environment.Type.FED_RAMP and isSelectedEnvironmentFedRamp stay in place. The tests match the change, and the imports left in LandingViewModel (map) and LandingViewModelTest (MutableStateFlow) are still used.

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.81%. Comparing base (262dba3) to head (19edc00).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7548      +/-   ##
==========================================
- Coverage   86.82%   86.81%   -0.01%     
==========================================
  Files         896      896              
  Lines       65792    65779      -13     
  Branches     9407     9406       -1     
==========================================
- Hits        57121    57108      -13     
  Misses       5187     5187              
  Partials     3484     3484              
Flag Coverage Δ
app-data 18.70% <0.00%> (+<0.01%) ⬆️
app-ui-auth-tools 18.60% <100.00%> (-0.02%) ⬇️
app-ui-platform 16.47% <0.00%> (+<0.01%) ⬆️
app-ui-vault 26.98% <0.00%> (+<0.01%) ⬆️
authenticator 6.02% <0.00%> (+<0.01%) ⬆️
lib-core-network-bridge 4.13% <0.00%> (+<0.01%) ⬆️
lib-data-ui 1.25% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trmartin4 trmartin4 changed the title [PM-37634] chore: Remove fedramp-gov-region feature flag (step 1) [PM-37634] Remove fedramp-gov-region feature flag (step 1) Oct 30, 2026
@trmartin4 trmartin4 added t:flagged-code-removal and removed t:tech-debt Change Type - Tech debt labels Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:flagged-code-removal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant