Repository navigation
Fix fallocate on Apple platforms. - #1708
Merged
Merged
Conversation
sunfishcode
force-pushed
the
sunfishcode/fallocate-macos
branch
2 times, most recently
from
October 15, 2026 20:05
0e687fe to
1892bf6
Compare
Always use `F_ALLOCATEALL` on Apple platforms to avoid partial success. Also, don't bother trying `F_ALLOCATECONTIG`, as that's not necessary to fulfill the `fallocate` contract. And, document `fallocate`'s behavior on Apple platforms, which lack `posix_fallocate`. Rustix in general doesn't like to be in the business of trying to provide portability abstractions like this, but it's awkward to change this particular function at this point.
sunfishcode
force-pushed
the
sunfishcode/fallocate-macos
branch
from
October 15, 2026 20:20
1892bf6 to
5d59062
Compare
sunfishcode
marked this pull request as ready for review
October 15, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
fallocateon Apple platforms.Always use
F_ALLOCATEALLon Apple platforms to avoid partial success.Also, don't bother trying
F_ALLOCATECONTIG, as that's not necessary to fulfill thefallocatecontract.And, document
fallocate's behavior on Apple platforms, which lackposix_fallocate. Rustix in general doesn't like to be in the business of trying to provide portability abstractions like this, but it's awkward to change this particular function at this point.Fixes #1682.