You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: the filter's created-at endpoint can be wrong by 100x and its parity suite still passes #981
The nearest invalid row in that file is 1_672_295_751_103 (crates/nostream-core/tests/filter_schema_parity.rs:211) — 167× the real limit. Every other created_at/since/until row sits far below 10⁸ as well, so nothing in the table lies between a wrong bound and a right one.
The port's event-side test does catch a constant change (wire_codec), so the gap is specific to the filter surface.
Why it matters
A parity suite that cannot fail is the thing this rewrite exists to prevent: it reports agreement while measuring nothing about the boundary it names. The created_at bound is one line, so the risk of a wrong value is low — but the precedent is not: any other endpoint in that table could be wrong by two orders of magnitude and pass.
What a fix needs
Rows at the boundary itself, on the filter surface:
since/until at 10_000_000_000 - 1 → accepted;
since/until at 10_000_000_000 → refused with the capture's message;
the same pair for until, and for a limit-style numeric field if one shares the code path.
The capture's own answer at those two points should be measured with messageSchema rather than assumed, since the port and the capture have already disagreed once on a boundary in this area.
Found while closing #960/#961 (PR #980): the substitution there is provably exact (10^10 < 2^53, so the as f64 cast cannot round), which is why it was accepted — but the test that would have caught a wrong value does not exist.
Merged as 15c42616b4bda2aaaf596ad02113806062b2ae4a (PR #1042, parents 0fa4150 + 8b131dd; the merged tree is git diff-empty against the reviewed commit).
The suite now fails when the created_at bound is wrong in either direction — the property the issue measured missing, where a 100× error left 54/54 green. It also covered a worse case found during the job: a filter-only mutation left the entire workspace green (942/0), so the blind spot was not confined to the parity suite.
Four rows, split by direction: 9_999_999_999 accepted (fails under too low a bound), 10_000_000_000 refused (fails under too high a bound). Proven by three inversions plus a base countercheck, each in its own archive copy.
Closed by hand because Closes #981 is inert on rewrite/main — the keyword closes only against the repository's default branch.
Activity
chappie-daemon commentedon Nov 3, 2026
Merged as
15c42616b4bda2aaaf596ad02113806062b2ae4a(PR #1042, parents0fa4150+8b131dd; the merged tree isgit diff-empty against the reviewed commit).The suite now fails when the
created_atbound is wrong in either direction — the property the issue measured missing, where a 100× error left 54/54 green. It also covered a worse case found during the job: a filter-only mutation left the entire workspace green (942/0), so the blind spot was not confined to the parity suite.Four rows, split by direction:
9_999_999_999accepted (fails under too low a bound),10_000_000_000refused (fails under too high a bound). Proven by three inversions plus a base countercheck, each in its own archive copy.Closed by hand because
Closes #981is inert onrewrite/main— the keyword closes only against the repository's default branch.