Skip to content

Fix the Rails 7.1 unrestorable busy wait test #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cardmagic merged 2 commits into from
Oct 3, 2026
Merged

Fix the Rails 7.1 unrestorable busy wait test #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4d8d4
test: install the busy handler the test assumes
cardmagic Oct 1, 2026
445cf27
ci: stop a hung job after 15 minutes
cardmagic Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
jobs:
sqlite:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1
Expand All @@ -19,6 +20,7 @@ jobs:

javascript:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
Expand All @@ -31,6 +33,7 @@ jobs:

compatibility:
runs-on: ubuntu-latest
timeout-minutes: 15
strategy:
fail-fast: false
matrix:
Expand All @@ -49,6 +52,7 @@ jobs:

redis:
runs-on: ubuntu-latest
timeout-minutes: 15
services:
redis:
image: redis:7
Expand All @@ -69,6 +73,7 @@ jobs:

postgresql:
runs-on: ubuntu-latest
timeout-minutes: 15
services:
postgres:
image: postgres:18
Expand All @@ -95,6 +100,7 @@ jobs:

mysql:
runs-on: ubuntu-latest
timeout-minutes: 15
# Both clients speak MySQL but report different adapter names, negotiate
# different connection collations, and name the same error code
# differently, so passing on one proves nothing about the other.
Expand Down Expand Up @@ -129,6 +135,7 @@ jobs:

static:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1
Expand All @@ -148,6 +155,7 @@ jobs:
- compatibility
- redis
runs-on: ubuntu-latest
timeout-minutes: 15
permissions:
contents: write
id-token: write
Expand Down
5 changes: 4 additions & 1 deletion test/integration/synchronous_invocation_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,10 @@ def wait(timeout:)
database_adapter = SolidObjects.database_adapter
database_adapter.define_singleton_method(:configured_busy_handler_timeout) { |_connection| nil }

SolidObjects::Record.connection_pool.with_connection do
SolidObjects::Record.connection_pool.with_connection do |connection|
connection.raw_connection.busy_handler_timeout = configured_sqlite_busy_handler_timeout
assert_equal 0, connection.select_value("PRAGMA busy_timeout").to_i

CounterActor.ref("unrestorable").increment

assert_nothing_raised do
Expand Down
Loading